From 32ea92ea305349d0dd3e0ada8c295422f821864a Mon Sep 17 00:00:00 2001 From: Amir Tahani Date: Mon, 16 Nov 2026 14:19:25 +0200 Subject: [PATCH 1/3] fix(ios): make embed metadata -sectcreate linker flag idempotent and surface setup errors --- lib/services/ios-project-service.ts | 43 +++++++++++++++++++++++----- test/ios-project-service.ts | 44 +++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+), 7 deletions(-) diff --git a/lib/services/ios-project-service.ts b/lib/services/ios-project-service.ts index 7ac6f30c0e..2fc1caf1e5 100644 --- a/lib/services/ios-project-service.ts +++ b/lib/services/ios-project-service.ts @@ -779,13 +779,13 @@ export class IOSProjectService // } // ); - const metadataPath = path.relative( - this.$options.hostProjectPath, - buildFolderPath, - ); - project.addToOtherLinkerFlags( + const metadataPath = path + .relative(this.$options.hostProjectPath, buildFolderPath) + .replace(/\\/g, "/"); + this.setHostMetadataLinkerFlag( + project, JSON.stringify( - `-sectcreate __DATA __TNSMetadata "${metadataPath}/metadata-arm64.bin"`, + `-sectcreate __DATA __TNSMetadata "${metadataPath}/metadata-$(CURRENT_ARCH).bin"`, ), ); @@ -820,7 +820,7 @@ export class IOSProjectService this.savePbxProj(project, projectData); } catch (err) { - this.$logger.trace( + this.$logger.error( "Error adding NativeScript group to host project", err, ); @@ -1971,6 +1971,35 @@ export class IOSProjectService } } } + + private setHostMetadataLinkerFlag( + project: any, + flag: string, + ): void { + const configurations = project.pbxXCBuildConfigurationSection(); + for (const key of Object.keys(configurations || {})) { + if (key.endsWith("_comment")) { + continue; + } + const buildSettings = configurations[key]?.buildSettings; + if (!buildSettings) { + continue; + } + const ldFlags = buildSettings.OTHER_LDFLAGS; + if (Array.isArray(ldFlags)) { + buildSettings.OTHER_LDFLAGS = ldFlags.filter( + (entry: string) => + !String(entry).includes("-sectcreate __DATA __TNSMetadata"), + ); + } else if ( + typeof ldFlags === "string" && + ldFlags.includes("-sectcreate __DATA __TNSMetadata") + ) { + delete buildSettings.OTHER_LDFLAGS; + } + } + project.addToOtherLinkerFlags(flag); + } } injector.register("iOSProjectService", IOSProjectService); diff --git a/test/ios-project-service.ts b/test/ios-project-service.ts index e55c28f3f2..191aa83cbf 100644 --- a/test/ios-project-service.ts +++ b/test/ios-project-service.ts @@ -1447,3 +1447,47 @@ describe("SPM Packages", () => { // todo: add tests for SPM packages }); }); + +describe("setHostMetadataLinkerFlag", () => { + it("removes duplicate -sectcreate __DATA __TNSMetadata flags and adds once idempotently", () => { + const dir = mkdtempSync(path.join(tmpdir(), "myTestProjectPath-")); + const testInjector = createTestInjector(dir, "myTestProjectName"); + const iOSProjectService = testInjector.resolve("iOSProjectService"); + + const addedFlags: string[] = []; + const mockConfig: any = { + buildSettings: { + PRODUCT_NAME: '"myTestProjectName"', + OTHER_LDFLAGS: [ + '"$(inherited)"', + '"-ObjC"', + '"-sectcreate __DATA __TNSMetadata \\"app/metadata-arm64.bin\\""', + '"-sectcreate __DATA __TNSMetadata \\"app/metadata-arm64.bin\\""', + ], + }, + }; + const mockProject: any = { + pbxXCBuildConfigurationSection: () => ({ + CFG1: mockConfig, + CFG1_comment: "Debug", + }), + addToOtherLinkerFlags: (flag: string) => { + mockConfig.buildSettings.OTHER_LDFLAGS.push(flag); + addedFlags.push(flag); + }, + }; + + const newFlag = JSON.stringify( + '-sectcreate __DATA __TNSMetadata "app/metadata-$(CURRENT_ARCH).bin"', + ); + iOSProjectService.setHostMetadataLinkerFlag(mockProject, newFlag); + iOSProjectService.setHostMetadataLinkerFlag(mockProject, newFlag); + + assert.deepStrictEqual(mockConfig.buildSettings.OTHER_LDFLAGS, [ + '"$(inherited)"', + '"-ObjC"', + newFlag, + ]); + assert.strictEqual(addedFlags.length, 2); + }); +}); From 2b7fba97e1c643d004926719ca807158bb7f7b5f Mon Sep 17 00:00:00 2001 From: Amir Tahani Date: Mon, 16 Nov 2026 14:32:42 +0200 Subject: [PATCH 2/3] fix(ios): preserve unrelated OTHER_LDFLAGS when stripping metadata directives --- lib/services/ios-project-service.ts | 29 +++++++++++----- test/ios-project-service.ts | 52 +++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+), 9 deletions(-) diff --git a/lib/services/ios-project-service.ts b/lib/services/ios-project-service.ts index 2fc1caf1e5..e823bc54e1 100644 --- a/lib/services/ios-project-service.ts +++ b/lib/services/ios-project-service.ts @@ -1976,6 +1976,15 @@ export class IOSProjectService project: any, flag: string, ): void { + const stripMetadataDirective = (value: string): string => + value + .replace( + /-sectcreate\s+__DATA\s+__TNSMetadata\s+(?:\\?"[^"]*\\?"|\S+)/g, + "", + ) + .replace(/\s{2,}/g, " ") + .trim(); + const configurations = project.pbxXCBuildConfigurationSection(); for (const key of Object.keys(configurations || {})) { if (key.endsWith("_comment")) { @@ -1987,15 +1996,17 @@ export class IOSProjectService } const ldFlags = buildSettings.OTHER_LDFLAGS; if (Array.isArray(ldFlags)) { - buildSettings.OTHER_LDFLAGS = ldFlags.filter( - (entry: string) => - !String(entry).includes("-sectcreate __DATA __TNSMetadata"), - ); - } else if ( - typeof ldFlags === "string" && - ldFlags.includes("-sectcreate __DATA __TNSMetadata") - ) { - delete buildSettings.OTHER_LDFLAGS; + buildSettings.OTHER_LDFLAGS = ldFlags + .map((entry: string) => stripMetadataDirective(String(entry))) + .filter((entry: string) => entry.length > 0 && entry !== '""'); + } else if (typeof ldFlags === "string") { + const cleaned = stripMetadataDirective(ldFlags); + if (!cleaned || cleaned === '""') { + delete buildSettings.OTHER_LDFLAGS; + } else if (cleaned !== '"$(inherited)"') { + // pbxProject.addToOtherLinkerFlags calls .push(), so convert scalar to array + buildSettings.OTHER_LDFLAGS = [cleaned]; + } } } project.addToOtherLinkerFlags(flag); diff --git a/test/ios-project-service.ts b/test/ios-project-service.ts index 191aa83cbf..c5adf66fb3 100644 --- a/test/ios-project-service.ts +++ b/test/ios-project-service.ts @@ -1490,4 +1490,56 @@ describe("setHostMetadataLinkerFlag", () => { ]); assert.strictEqual(addedFlags.length, 2); }); + + it("preserves unrelated linker flags in scalar strings and multi-directive array elements", () => { + const dir = mkdtempSync(path.join(tmpdir(), "myTestProjectPath-")); + const testInjector = createTestInjector(dir, "myTestProjectName"); + const iOSProjectService = testInjector.resolve("iOSProjectService"); + + const scalarConfig: any = { + buildSettings: { + PRODUCT_NAME: '"myTestProjectName"', + OTHER_LDFLAGS: + '$(inherited) -ObjC -sectcreate __DATA __TNSMetadata "app/metadata-arm64.bin" -lHostDep', + }, + }; + const multiArrayConfig: any = { + buildSettings: { + PRODUCT_NAME: '"myTestProjectName"', + OTHER_LDFLAGS: [ + '"$(inherited)"', + '-ObjC -sectcreate __DATA __TNSMetadata "app/metadata-arm64.bin" -lOther', + ], + }, + }; + const mockProject: any = { + pbxXCBuildConfigurationSection: () => ({ + SCALAR: scalarConfig, + MULTI: multiArrayConfig, + }), + addToOtherLinkerFlags: (flag: string) => { + for (const cfg of [scalarConfig, multiArrayConfig]) { + if (!Array.isArray(cfg.buildSettings.OTHER_LDFLAGS)) { + cfg.buildSettings.OTHER_LDFLAGS = ['"$(inherited)"']; + } + cfg.buildSettings.OTHER_LDFLAGS.push(flag); + } + }, + }; + + const newFlag = JSON.stringify( + '-sectcreate __DATA __TNSMetadata "app/metadata-$(CURRENT_ARCH).bin"', + ); + iOSProjectService.setHostMetadataLinkerFlag(mockProject, newFlag); + + assert.deepStrictEqual(scalarConfig.buildSettings.OTHER_LDFLAGS, [ + "$(inherited) -ObjC -lHostDep", + newFlag, + ]); + assert.deepStrictEqual(multiArrayConfig.buildSettings.OTHER_LDFLAGS, [ + '"$(inherited)"', + "-ObjC -lOther", + newFlag, + ]); + }); }); From 3a59109e030f7df747de1d6c5f996751008238f2 Mon Sep 17 00:00:00 2001 From: Amir Tahani Date: Mon, 16 Nov 2026 14:46:21 +0200 Subject: [PATCH 3/3] fix(ios): refine metadata directive regex and preserve unchanged whitespace --- lib/services/ios-project-service.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/services/ios-project-service.ts b/lib/services/ios-project-service.ts index e823bc54e1..fc75967347 100644 --- a/lib/services/ios-project-service.ts +++ b/lib/services/ios-project-service.ts @@ -1976,14 +1976,17 @@ export class IOSProjectService project: any, flag: string, ): void { - const stripMetadataDirective = (value: string): string => - value + const stripMetadataDirective = (value: string): string => { + const stripped = value .replace( - /-sectcreate\s+__DATA\s+__TNSMetadata\s+(?:\\?"[^"]*\\?"|\S+)/g, + /-sectcreate\s+__DATA\s+__TNSMetadata\s+(?:\\?"[^"]*\\?"|[^\s"]+)/g, "", - ) - .replace(/\s{2,}/g, " ") - .trim(); + ); + if (stripped === value) { + return value; + } + return stripped.replace(/\s{2,}/g, " ").trim(); + }; const configurations = project.pbxXCBuildConfigurationSection(); for (const key of Object.keys(configurations || {})) {