From f4d68394a14f91bd653d63cc71ad4008c2e5e69c Mon Sep 17 00:00:00 2001 From: Ian Thomas Date: Wed, 18 Nov 2026 12:12:54 +0000 Subject: [PATCH] Fix default directory in git init --- src/subcommand/init_subcommand.cpp | 9 +++++++-- test/test_init.py | 8 ++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/subcommand/init_subcommand.cpp b/src/subcommand/init_subcommand.cpp index 9a83f35..b9e290f 100644 --- a/src/subcommand/init_subcommand.cpp +++ b/src/subcommand/init_subcommand.cpp @@ -16,8 +16,8 @@ init_subcommand::init_subcommand(const libgit2_object&, CLI::App& app) m_directory, "Directory to create the repository in, created if it does not exist. Defaults to the current directory." ) - ->check(CLI::ExistingDirectory | CLI::NonexistentPath) - ->default_val(get_current_git_path()); + ->check(CLI::ExistingDirectory | CLI::NonexistentPath); + sub->add_option( "-b,--initial-branch", m_branch, @@ -34,6 +34,11 @@ init_subcommand::init_subcommand(const libgit2_object&, CLI::App& app) void init_subcommand::run() { + if (m_directory.empty()) + { + m_directory = get_current_git_path(); + } + std::filesystem::path target_dir = m_directory; bool reinit = std::filesystem::exists(target_dir / ".git" / "HEAD"); diff --git a/test/test_init.py b/test/test_init.py index dcd8267..6965c8d 100644 --- a/test/test_init.py +++ b/test/test_init.py @@ -186,3 +186,11 @@ def test_init_filemode(git2cpp_path, tmp_path): assert filemode_lines == ["core.filemode=false", "core.filemode=false"] else: assert filemode_lines == ["core.filemode=false"] + + +def test_init_help_has_no_default_directory(git2cpp_path, tmp_path, run_in_tmp_path): + cmd = [git2cpp_path, "init", "--help"] + p = subprocess.run(cmd, capture_output=True, text=True) + assert p.returncode == 0 + assert "directory" in p.stdout + assert str(tmp_path) not in p.stdout