Repository navigation
ci: fetch Vineflower by the plugin's coordinates, and try a failed fetch again - #2030
Merged
Merged
Conversation
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
November 19, 2026 05:14
…tch again `mvn dependency:get` resolves the `dependency` prefix from Maven Central's plugin-group metadata. When that read fails, Maven stops with "No plugin found for prefix 'dependency'" and the Java engine job fails before a test runs. It happened on the pull request that merged 0.2.4 into dev, on the first run and on the rerun, while the push of the same commit passed. The step now names maven-dependency-plugin 3.11.0 in full, so no prefix lookup takes place, and tries the download up to three times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2029
What changed
The Java engine job fetches Vineflower (the decompiler
--library autouses for class jars) withmvn -q dependency:get. Maven resolves thedependency:prefix from Maven Central's plugin-group metadata, and when that read fails it stops with:The job then fails before any Java case runs. This happened on #2029 (0.2.4 into dev), on the first run and on the rerun of the failed job, while the push of the same commit to dev passed. No other run in the last 40 failed at this step.
org.apache.maven.plugins:maven-dependency-plugin:3.11.0:get), so there is no prefix lookup.Why the goldens moved, or why they did not
No golden moved. Workflow only.
Evidence
Against an empty local repository and plain Maven Central settings, the new command downloads
org/vineflower/vineflower/1.10.1/vineflower-1.10.1.jarand exits 0. The workflow file parses as YAML.