Repository navigation
Conversation
The server parses the page-size query parameter as `limit` (applicationListQuerySchema in bindist-terraform's validation.ts; default 20, max 100) and never looks at `pageSize`. Every request this client sent was therefore silently capped at the default 20 rows, with no error to indicate the requested size had been discarded. The public option keeps its existing name so callers are unaffected; only the wire parameter changes. A doc comment on the field records that the two names differ on purpose. The Rust client already sent `limit` and is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GkhmPJLKvghmHZ5avEVQeN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The API reads the page-size query parameter as
limit—applicationListQuerySchemainbindist-terraform/src/shared/utils/validation.ts, default 20, max 100 — andparseListQueryonly ever looks atparams.limit. The stringpageSizeappears nowhere in the server source.This client sent
pageSize. The server discarded it and fell back to the default, so every paged request returned 20 rows no matter what the caller asked for, and nothing surfaced an error to say the requested size had been dropped.The fix
Send
limiton the wire.The public option keeps its existing name, so this is not a breaking change for callers — only the query string differs. A doc comment on the field records that the option name and the parameter name differ deliberately, so the next reader doesn't "correct" it back.
Scope
Found while auditing the pagination contract across all six clients. Five of them sent
pageSize; the Rust client already sentlimitand was treated as the reference. Companion PRs go to the Go, Python, JavaScript and Delphi clients; the (as yet unpublished) .NET client is fixed locally.Two related server-side gaps found in the same pass, not addressed here:
GET /v1/activityacceptslimitonly (default 50, max 100) — there is nopageparameter, though some clients send one.GET /v1/management/customersparses no query parameters at all and returns every customer, despite client signatures that promise pagination.🤖 Generated with Claude Code
https://claude.ai/code/session_01GkhmPJLKvghmHZ5avEVQeN
Verification
black --checkand strictmypypass locally; CI green on this branch.