Skip to content

chore(deps): upgrade nix to v0.32 - #203

Merged
not-matthias merged 2 commits into
CodSpeedHQ:mainfrom
xtqqczze:deps-nix
Nov 18, 2026
Merged

not-matthias merged 2 commits into
CodSpeedHQ:mainfrom
xtqqczze:deps-nix

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #206.

Widen the accepted version range of the nix crate to >=0.30.0, <0.33.0 to improve dependency resolution and avoid duplicate versions of nix in downstream crates.

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The dependency update appears safe to merge; no actionable regression was found.

Summary

Updates codspeed to use nix 0.32.0.

  • CodSpeed uses nix 0.32.0 for Linux timestamps.

Reviews (1) · Last reviewed commit: "chore(deps): upgrade nix to v0.32" · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 4 benchmarks

3 warnings, 1 note

⚠️ Unable to measure the execution of 59 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 17 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 57 benchmarks have no flamegraph

  • The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze. (9 benchmarks)
  • The flamegraph wasn't generated: no execution data was recorded while the benchmark ran. Make sure the compiler didn't optimize the benchmark out. (48 benchmarks)

See affected benchmarks

⚡ 7 improved benchmarks
❌ 4 regressed benchmarks
✅ 607 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime iterative[10] 17 ns 35 ns -51.43%
❌ Walltime rat_in_maze[6] 860 ns 1,235 ns -30.36%
❌ CPU Simulation spawn_on_parent_runtime 33.3 µs 38.8 µs -14.12%
❌ Walltime zeroed_buffer[1] 48.9 µs 51 µs -4.3%
⚡ Walltime find_highest_set_bit[0] 7 ns 5 ns +40%
⚡ Walltime spawn_on_parent_runtime 25.5 µs 19.8 µs +28.39%
⚡ Walltime vec_copy_with_bytes_counter 59 ns 47 ns +25.53%
⚡ Walltime from_elem[8192] 628 ns 511 ns +22.9%
⚡ Walltime recursive_memoized[HashMap<u64, u64>, 10] 2.1 µs 1.8 µs +17.46%
⚡ Walltime count_set_bits[255] 8 ns 7 ns +14.29%
⚡ Walltime sleep_1ms 1.1 ms 1 ms +2.81%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:deps-nix (d569151) with main (1e075ad)

Open in CodSpeed

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@not-matthias please take a look

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

Actually is there any reason we should pin it to <0.33.0?

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Actually is there any reason we should pin it to <0.33.0?

Future versions of nix may introduce breaking changes that could make them incompatible. It's generally best to avoid open-ended version ranges.

@not-matthias
not-matthias merged commit 0c6d629 into CodSpeedHQ:main Nov 18, 2026
45 of 46 checks passed
@xtqqczze
xtqqczze deleted the deps-nix branch November 18, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade rust crate nix to v0.32

3 participants