Skip to content

fix(cargo-codspeed): exit successfully for help and version - #208

Open
konstin wants to merge 2 commits into
CodSpeedHQ:mainfrom
konstin:konsti/cargo-codspeed-help-version-exit
Open

konstin wants to merge 2 commits into
CodSpeedHQ:mainfrom
konstin:konsti/cargo-codspeed-help-version-exit

Conversation

@konstin

@konstin konstin commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

I noticed that --help and --version currently exit with 1, which breaks our smoke tests.

We could make this simpler with Cli::parse_from(args) if changing the error code for invalid arguments from 1 to 2 is acceptable.

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable issues were found.

Summary

Help and version requests now use Clap’s normal output and successful exit behavior.

  • Help and version requests now exit successfully.

Reviews (1) · Last reviewed commit: "fix(cargo-codspeed): exit successfully f..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 3%

2 warnings, 1 note

⚠️ Unable to measure the execution of 59 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 17 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 57 benchmarks have no flamegraph

  • The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze. (9 benchmarks)
  • The flamegraph wasn't generated: no execution data was recorded while the benchmark ran. Make sure the compiler didn't optimize the benchmark out. (48 benchmarks)

See affected benchmarks

⚡ 7 improved benchmarks
❌ 11 regressed benchmarks
✅ 600 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime count_set_bits[42] 7 ns 14 ns -50%
❌ Walltime mul 2 ns 3 ns -33.33%
❌ Walltime iter_batched_ref_large_input 8 ns 11 ns -27.27%
❌ Walltime rem 5 ns 6 ns -16.67%
❌ Walltime iter_batched_large_input 7 ns 8 ns -12.5%
❌ Walltime graph_coloring[6] 1.2 µs 1.2 µs -6.04%
❌ Walltime recursive[5] 35 ns 37 ns -5.41%
❌ Walltime add_two_integers[(42, 13)] 19 ns 20 ns -5%
❌ Walltime iter_with_setup 40 ns 42 ns -4.76%
❌ Walltime n_queens_solver[4] 2.1 µs 2.2 µs -4.33%
❌ Walltime zeroed_buffer[1] 48.9 µs 50.4 µs -3.05%
⚡ Walltime process_with_multiple_counters 46 ns 30 ns +53.33%
⚡ Walltime spawn_on_parent_runtime 25.5 µs 18.2 µs +40.09%
⚡ Walltime find_highest_set_bit[0] 7 ns 5 ns +40%
⚡ Walltime bench_array2[42] 41 ns 35 ns +17.14%
⚡ Walltime recursive_memoized[HashMap<u64, u64>, 10] 2.1 µs 1.8 µs +14.39%
⚡ Walltime add_two_integers[(255, 255)] 20 ns 19 ns +5.26%
⚡ Walltime from_elem_decimal[1024] 215 ns 208 ns +3.37%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing konstin:konsti/cargo-codspeed-help-version-exit (2e5d3e5) with main (1e075ad)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant