Repository navigation
chore: bump samply-codspeed to mark truncated and failed stacks - #629
not-matthias wants to merge 1 commit into
Conversation
Merging this PR will improve performance by 23.54%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
[Medium impact] The update affects Linux wall-time profiling through the runner's bundled sampler. The PR appears safe to merge, with a non-blocking concern about memory use while profiling deep recursion.
|
| @@ -1 +1 @@ | |||
| Subproject commit 030f8275372ac74dfe47f4e619e8703e9354c600 | |||
| Subproject commit 13e8116b47dda27f3326bf8fb28afabd26e4b46e | |||
There was a problem hiding this comment.
Overlapping stack copies pile up
The new cache keeps every 32,000-byte stack window during a slow recursive descent. Each window ends below the previous one, so ThreadStackSnapshots::push retains the older copies. retire_returned also keeps them while sp moves downward.
For example, 10,000 sampled depths retain about 320 MB per thread, and each new sample scans the growing list twice. The old cache stored only words read during unwinding, keyed by address. Consider capping retained bytes or compacting overlapping windows to keep profiling costs predictable.
Prompt To Fix With AI
This is a comment left during a code review.
Path: crates/samply-codspeed
Line: 1
Comment:
**Overlapping stack copies pile up**
The new cache keeps every 32,000-byte stack window during a slow recursive descent. Each window ends below the previous one, so `ThreadStackSnapshots::push` retains the older copies. `retire_returned` also keeps them while `sp` moves downward.
For example, 10,000 sampled depths retain about 320 MB per thread, and each new sample scans the growing list twice. The old cache stored only words read during unwinding, keyed by address. Consider capping retained bytes or compacting overlapping windows to keep profiling costs predictable.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Closes COD-4293.
Bumps the pinned
crates/samply-codspeedsubmodule from030f8275to13e8116bso the truncated/failed stack markers land in the runner.Included upstream commits:
cargo check --workspacepasses locally.