Skip to content

feat(spanner): Add online default_leader DDL update sample - #14948

Open
iennae wants to merge 3 commits into
feat/spanner-create-databasefrom
feat/spanner-update-database-with-default-leader
Open

iennae wants to merge 3 commits into
feat/spanner-create-databasefrom
feat/spanner-update-database-with-default-leader

Conversation

@iennae

@iennae iennae commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Description

Adds spanner_update_database_with_default_leader updating the default_leader option on an existing multi-region database.

Note: Stacked on #14943 (feat/spanner-create-database) so this PR shows only this sample's diff. It will merge into main after #14943.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended. Unit and live integration tests pass on Python 3.13.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

Multi-region Spanner databases can migrate write leadership online using ALTER DATABASE ... SET OPTIONS (default_leader = ...) via UpdateDatabaseDdl. Add spanner_update_database_with_default_leader.
@iennae
iennae requested review from a team as code owners November 18, 2026 22:18
@snippet-bot

snippet-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Nov 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script and associated tests to update a Google Cloud Spanner database's default leader using DDL statements. Specifically, it adds update_database_with_default_leader.py which contains the logic to execute the ALTER DATABASE statement and handle potential errors, alongside a CLI entry point. It also adds comprehensive unit and live tests in update_database_with_default_leader_test.py to verify the functionality. There are no review comments, and I have no additional feedback to provide.

…_default_leader

Problem: multi-line SQL and DDL statements were written as adjacent string
fragments. That style is easy to get wrong (a missing trailing space joins
two SQL tokens) and is harder to read than the statement itself, and the
samples in this set mixed it with triple-quoted SQL.

Solution: write each multi-line statement as a single triple-quoted string,
matching the layout already used by the other samples. Only whitespace
between SQL tokens changes; the statements are otherwise identical.

Files updated:
  - spanner/database_admin/src/spanner_database_admin/update_database_with_default_leader.py
…t_leader

Problem: review of this sample identified correctness and robustness
improvements in the sample and its tests.

Solution: apply the accepted review suggestions and extend the tests to
cover the updated behavior. Details are in the review thread replies.

Files updated:
  - spanner/database_admin/tests/update_database_with_default_leader_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant