Skip to content

feat(spanner): Add GoogleSQL online CREATE INDEX DDL sample - #14952

Open
iennae wants to merge 1 commit into
feat/spanner-create-databasefrom
feat/spanner-create-index
Open

iennae wants to merge 1 commit into
feat/spanner-create-databasefrom
feat/spanner-create-index

Conversation

@iennae

@iennae iennae commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Description

Adds spanner_create_index creating a GoogleSQL secondary index online via DatabaseAdminClient.update_database_ddl.

Note: Stacked on #14943 (feat/spanner-create-database) so this PR shows only this sample's diff. It will merge into main after #14943.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended. Unit and live integration tests pass on Python 3.13.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

Secondary index guides build indexes online without blocking reads or writes via DatabaseAdminClient.update_database_ddl. Add a standalone spanner_create_index sample creating AlbumsByAlbumTitle.
@iennae
iennae requested review from a team as code owners November 18, 2026 22:18
@snippet-bot

snippet-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Nov 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script and associated tests for creating a secondary index on a Google Cloud Spanner database. Specifically, create_index.py defines a create_index function that executes a DDL statement to index Albums(AlbumTitle) and handles various API exceptions and timeouts. It also includes a CLI entry point. The accompanying test file, create_index_test.py, provides comprehensive unit and live integration tests to verify successful execution, error handling, and CLI functionality. There are no review comments, and the implementation looks solid, so I have no additional feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant