Skip to content

chore: oxlint with oxfmt - #6120

Open
NathanWalker wants to merge 1 commit into
mainfrom
feat/oxc
Open

NathanWalker wants to merge 1 commit into
mainfrom
feat/oxc

Conversation

@NathanWalker

Copy link
Copy Markdown
Contributor

Swap prettier/eslint with oxfmt/oxlint.

Measured before the conversion, on the full lib/ + test/ source tree: 527 TypeScript files, ~117k lines. Each command ran 5 times after 1 warmup run (Node child process, cold start included), on an Apple M3 Max (16 threads), Node v24.1.0.

Task Tool Mean Min Max Speedup
Format check prettier 3.9.6 --check 2,228 ms 2,199 ms 2,262 ms 1×
Format check oxfmt 0.61.0 --check 239 ms 236 ms 243 ms ~9.3×
Lint ESLint 10.8.0 + typescript-eslint 8.65.0 (recommended) 1,932 ms 1,917 ms 1,956 ms 1×
Lint oxlint 1.76.0 589 ms 583 ms 600 ms ~3.4×

@NathanWalker
NathanWalker requested a review from edusperoni August 3, 2026 02:00
@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 255 files, which is 105 over the limit of 150.

To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c891559f-6e22-46c6-b2b4-2c8cf6037b7b
Commits

Reviewing files that changed from the base of the PR and between f95fde9 and e998cfe.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 255

  • .github/workflows/tests.yml
  • .oxfmtrc.json
  • .oxlintrc.json
  • .prettierrc.json
  • CONTRIBUTING.md
  • lib/base-package-manager.ts
  • lib/bun-package-manager.ts
  • lib/commands/clean.ts
  • lib/commands/native-add.ts
  • lib/common/codeGeneration/code-generation.d.ts
  • lib/common/constants.ts
  • lib/common/declarations.d.ts
  • lib/common/decorators.ts
  • lib/common/define-command.ts
  • lib/common/definitions/config.d.ts
  • lib/common/definitions/json-file-settings-service.d.ts
  • lib/common/definitions/mobile.d.ts
  • lib/common/di/injector.ts
  • lib/common/di/providers.ts
  • lib/common/helpers.ts
  • lib/common/host-info.ts
  • lib/common/http-client.ts
  • lib/common/logger/appenders/emit-appender.ts
  • lib/common/messages/messages.ts
  • lib/common/mobile/android/android-debug-bridge-result-handler.ts
  • lib/common/mobile/android/android-debug-bridge.ts
  • lib/common/mobile/android/android-device-file-system.ts
  • lib/common/mobile/android/android-device-hash-service.ts
  • lib/common/mobile/android/android-device.ts
  • lib/common/mobile/android/android-emulator-services.ts
  • lib/common/mobile/android/android-ini-file-parser.ts
  • lib/common/mobile/android/android-log-filter.ts
  • lib/common/mobile/android/device-android-debug-bridge.ts
  • lib/common/mobile/android/genymotion/genymotion-service.ts
  • lib/common/mobile/android/genymotion/virtualbox-service.ts
  • lib/common/mobile/android/logcat-helper.ts
  • lib/common/mobile/application-manager-base.ts
  • lib/common/mobile/device-emitter.ts
  • lib/common/mobile/device-log-emitter.ts
  • lib/common/mobile/device-log-provider-base.ts
  • lib/common/mobile/device-log-provider.ts
  • lib/common/mobile/ios/device/ios-application-manager.ts
  • lib/common/mobile/ios/device/ios-device.ts
  • lib/common/mobile/ios/ios-device-base.ts
  • lib/common/mobile/ios/ios-log-filter.ts
  • lib/common/mobile/ios/simulator/ios-emulator-services.ts
  • lib/common/mobile/ios/simulator/ios-sim-resolver.ts
  • lib/common/mobile/ios/simulator/ios-simulator-application-manager.ts
  • lib/common/mobile/ios/simulator/ios-simulator-device.ts
  • lib/common/mobile/ios/simulator/ios-simulator-file-system.ts
  • lib/common/mobile/ios/simulator/ios-simulator-log-provider.ts
  • lib/common/mobile/local-to-device-path-data-factory.ts
  • lib/common/mobile/log-filter.ts
  • lib/common/mobile/mobile-core/android-device-discovery.ts
  • lib/common/mobile/mobile-core/android-emulator-discovery.ts
  • lib/common/mobile/mobile-core/android-process-service.ts
  • lib/common/mobile/mobile-core/device-discovery.ts
  • lib/common/mobile/mobile-core/devices-service.ts
  • lib/common/mobile/mobile-core/ios-device-discovery.ts
  • lib/common/mobile/mobile-helper.ts
  • lib/common/project-helper.ts
  • lib/common/prompter.ts
  • lib/common/resource-loader.ts
  • lib/common/services/auto-completion-service.ts
  • lib/common/services/help-service.ts
  • lib/common/services/ios-notification-service.ts
  • lib/common/services/json-file-settings-service.ts
  • lib/common/services/lock-service.ts
  • lib/common/services/message-contract-generator.ts
  • lib/common/services/messages-service.ts
  • lib/common/services/micro-templating-service.ts
  • lib/common/services/project-files-manager.ts
  • lib/common/services/project-files-provider-base.ts
  • lib/common/services/proxy-service.ts
  • lib/common/services/settings-service.ts
  • lib/common/services/xcode-select-service.ts
  • lib/common/test/test-bootstrap.ts
  • lib/common/test/unit-tests/android-application-manager.ts
  • lib/common/test/unit-tests/android-log-filter.ts
  • lib/common/test/unit-tests/appbuilder/device-log-provider.ts
  • lib/common/test/unit-tests/helpers.ts
  • lib/common/test/unit-tests/host-info.ts
  • lib/common/test/unit-tests/ios-log-filter.ts
  • lib/common/test/unit-tests/log-filter.ts
  • lib/common/test/unit-tests/logger.ts
  • lib/common/test/unit-tests/messages-service.ts
  • lib/common/test/unit-tests/mobile/android-debug-bridge.ts
  • lib/common/test/unit-tests/mobile/android-device-discovery.ts
  • lib/common/test/unit-tests/mobile/android-device-file-system.ts
  • lib/common/test/unit-tests/mobile/android-virtual-device-service.ts
  • lib/common/test/unit-tests/mobile/android/logcat-helper.ts
  • lib/common/test/unit-tests/mobile/application-manager-base.ts
  • lib/common/test/unit-tests/mobile/device-log-provider.ts
  • lib/common/test/unit-tests/mobile/devices-service.ts
  • lib/common/test/unit-tests/mobile/genymotion/genymotion-service.ts
  • lib/common/test/unit-tests/mobile/ios-simulator-discovery.ts
  • lib/common/test/unit-tests/mocks/decorators-invoke-before.ts
  • lib/common/test/unit-tests/project-files-provider-base.ts
  • lib/common/test/unit-tests/services/files-hash-service.ts
  • lib/common/test/unit-tests/services/help-service.ts
  • lib/common/test/unit-tests/services/json-file-settings-service.ts
  • lib/common/test/unit-tests/services/net-service.ts
  • lib/common/test/unit-tests/stubs.ts
  • lib/common/test/unit-tests/xcode-select-service.ts
  • lib/common/utils.ts
  • lib/common/validators/project-name-validator.ts
  • lib/common/verify-node-version.ts
  • lib/common/yok.ts
  • lib/constants.ts
  • lib/contracts/package-manager.ts
  • lib/contracts/project-data-service.ts
  • lib/contracts/prompter.ts
  • lib/controllers/build-controller.ts
  • lib/controllers/debug-controller.ts
  • lib/controllers/migrate-controller.ts
  • lib/controllers/platform-controller.ts
  • lib/controllers/update-controller-base.ts
  • lib/controllers/update-controller.ts
  • lib/data/controller-data-base.ts
  • lib/data/platform-data.ts
  • lib/data/run-data.ts
  • lib/declarations.d.ts
  • lib/definitions/build.d.ts
  • lib/definitions/debug.d.ts
  • lib/definitions/files-hash-service.d.ts
  • lib/definitions/gradle.d.ts
  • lib/definitions/livesync.d.ts
  • lib/definitions/lock-service.d.ts
  • lib/definitions/marking-mode-service.d.ts
  • lib/definitions/migrate.d.ts
  • lib/definitions/nativescript-dev-xcode.d.ts
  • lib/definitions/pacote-service.d.ts
  • lib/definitions/platform.d.ts
  • lib/definitions/plugins.d.ts
  • lib/definitions/prepare.d.ts
  • lib/definitions/terminal-spinner-service.d.ts
  • lib/detached-processes/cleanup-js-subprocess.ts
  • lib/device-path-provider.ts
  • lib/device-sockets/ios/notification.ts
  • lib/device-sockets/ios/socket-request-executor.ts
  • lib/helpers/android-bundle-validator-helper.ts
  • lib/helpers/deploy-command-helper.ts
  • lib/helpers/options-track-helper.ts
  • lib/helpers/platform-command-helper.ts
  • lib/helpers/version-validator-helper.ts
  • lib/nativescript-cli-lib-bootstrap.ts
  • lib/nativescript-cli.ts
  • lib/node-package-manager.ts
  • lib/options.ts
  • lib/package-installation-manager.ts
  • lib/package-manager.ts
  • lib/pnpm-package-manager.ts
  • lib/providers/project-files-provider.ts
  • lib/resolvers/livesync-service-resolver.ts
  • lib/services/analytics/analytics.d.ts
  • lib/services/android-device-debug-service.ts
  • lib/services/android-project-service.ts
  • lib/services/android-resources-migration-service.ts
  • lib/services/android/gradle-build-service.ts
  • lib/services/android/gradle-command-service.ts
  • lib/services/apple-portal/apple-portal-application-service.ts
  • lib/services/apple-portal/apple-portal-cookie-service.ts
  • lib/services/apple-portal/definitions.d.ts
  • lib/services/apple-portal/srp/srp-wrapper.ts
  • lib/services/build-artifacts-service.ts
  • lib/services/build-info-file-service.ts
  • lib/services/cocoapods-platform-manager.ts
  • lib/services/cocoapods-service.ts
  • lib/services/debug-data-service.ts
  • lib/services/doctor-service.ts
  • lib/services/files-hash-service.ts
  • lib/services/hmr-status-service.ts
  • lib/services/ios-device-debug-service.ts
  • lib/services/ios-extensions-service.ts
  • lib/services/ios-log-filter.ts
  • lib/services/ios-native-target-service.ts
  • lib/services/ios-project-service.ts
  • lib/services/ios-provision-service.ts
  • lib/services/ios-watch-app-service.ts
  • lib/services/ios/export-options-plist-service.ts
  • lib/services/ios/xcodebuild-args-service.ts
  • lib/services/ios/xcodebuild-service.ts
  • lib/services/ip-service.ts
  • lib/services/itmstransporter-service.ts
  • lib/services/key-shortcuts.ts
  • lib/services/livesync/android-device-livesync-service-base.ts
  • lib/services/livesync/android-device-livesync-service.ts
  • lib/services/livesync/android-livesync-service.ts
  • lib/services/livesync/android-livesync-tool.ts
  • lib/services/livesync/device-livesync-service-base.ts
  • lib/services/livesync/ios-device-livesync-service.ts
  • lib/services/livesync/livesync-socket.ts
  • lib/services/livesync/platform-livesync-service-base.ts
  • lib/services/log-parser-service.ts
  • lib/services/log-source-map-service.ts
  • lib/services/marking-mode-service.ts
  • lib/services/metadata-filtering-service.ts
  • lib/services/performance-service.ts
  • lib/services/platform-environment-requirements.ts
  • lib/services/platform-project-service-base.ts
  • lib/services/platform/add-platform-service.ts
  • lib/services/platform/platform-validation-service.ts
  • lib/services/platform/prepare-native-platform-service.ts
  • lib/services/platforms-data-service.ts
  • lib/services/project-changes-service.ts
  • lib/services/project-cleanup-service.ts
  • lib/services/project-data-service.ts
  • lib/services/project-service.ts
  • lib/services/project-templates-service.ts
  • lib/services/timeline-profiler-service.ts
  • lib/services/user-settings-service.ts
  • lib/services/versions-service.ts
  • lib/services/xcproj-service.ts
  • lib/tools/config-manipulation/config-transformer.ts
  • lib/tools/node-modules/node-modules-builder.ts
  • lib/tools/node-modules/node-modules-dependencies-builder.ts
  • lib/yarn-package-manager.ts
  • lib/yarn2-package-manager.ts
  • package.json
  • test/bun-package-manager.ts
  • test/cocoapods-service.ts
  • test/controllers/update-controller.ts
  • test/define-command.ts
  • test/helpers/platform-command-helper.ts
  • test/ios-project-service.ts
  • test/node-package-manager.ts
  • test/package-installation-manager.ts
  • test/post-install.ts
  • test/preuninstall.ts
  • test/project-files-provider.ts
  • test/project-name-service.ts
  • test/project-service.ts
  • test/project-templates-service.ts
  • test/services/android-device-debug-service.ts
  • test/services/android-plugin-build-service.ts
  • test/services/android-project-service.ts
  • test/services/ios-debugger-port-service.ts
  • test/services/ios-device-debug-service.ts
  • test/services/ios-log-filter.ts
  • test/services/ios/export-options-plist-service.ts
  • test/services/ios/xcodebuild-service.ts
  • test/services/ip-service.ts
  • test/services/livesync/android-device-livesync-service-base.ts
  • test/services/livesync/android-livesync-tool.ts
  • test/services/livesync/ios-device-livesync-service.ts
  • test/services/log-parser-service.ts
  • test/services/log-source-map-service.ts
  • test/services/metadata-filtering-service.ts
  • test/services/platform-environment-requirements.ts
  • test/services/platform/add-platform-service.ts
  • test/services/test-execution-service.ts
  • test/services/user-settings-service.ts
  • test/stubs.ts
  • test/type-fixtures/define-command-types.ts
  • tslint.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant