Repository navigation
The split NOR layout for every board whose kernel has it; no fixed-slot package - #265
Conversation
PR Summary by QodoEnable split NOR packages for five overflowing 8 MB boards
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
…ot package The split layout is the NOR layout from here on. Every builder board whose SoC family has a split kernel now builds firmware.bin and ships only <device>-nor-split.tgz: - 78 boards on fixed slots gain post-image-split.sh; nine of them carry their own kernel config, which now has firmware's mtdsplit options (CONFIG_MTD_SPLIT_LAYOUT on Ingenic, the MTD_SPLIT_FIRMWARE set on HiSilicon and Goke). - the 18 infinity6e boards (ssc338q, ssc30kq, ssc30kd) too, on the kernel support OpenIPC/linux and OpenIPC/firmware add for that family. - BR2_OPENIPC_NOR_FIXED_PACKAGE goes from all 48 defconfigs that had it. sysupgrade turns the <device>-nor.tgz URL customizer.sh writes into <device>-nor-split.tgz itself, and the manifest falls back to the split package, so neither needs the fixed one. The last fixed package stays in the release as the bridge for cameras whose sysupgrade predates the layout. Still fixed, as firmware has no split kernel for them: xm530, s3l, ak3918ev300, and the two unbuilt gk7102ca profiles.
a7eea54 to
4fed5b6
Compare
The split layout is the NOR layout from here on. This moves every builder board that can boot it, and drops the fixed-slot package everywhere.
Boards
post-image-split.sh. Among them are the five that fail every nightly atrepackwithsize exceeded:hi3516ev200_lte,hi3516ev300_lte,gk7202v300_lite_generic-w7,t31_lite_chinatelecom-y4h-50andt31_lite_tp-link-tapo-tc70-v3. Nine of the 78 carry their own kernel config, and those now get firmware's mtdsplit options:CONFIG_MTD_SPLIT_LAYOUTon Ingenic, and theMTD_SPLIT_FIRMWARE/UIMAGE_FW/SQUASHFS_ROOT/MTD_ROOTFS_ROOT_DEVset on HiSilicon and Goke.ssc338q,ssc30kq,ssc30kd, includingssc338q_wfbng/ssc30kq_wfbng, which are 8 KB over). This needs infinity6e: the split NOR layout, without a device tree linux#279 and sigmastar infinity6e: the split NOR image firmware#2918 merged first; until thenpost-image-split.shrefuses their kernel.BR2_OPENIPC_NOR_FIXED_PACKAGEis removed from all 48 defconfigs that set it. Firmware drops the option in NOR: the split package is the only one; drop BR2_OPENIPC_NOR_FIXED_PACKAGE firmware#2919.Still on fixed slots, because firmware has no split kernel for them:
xm530(2),s3l(1),ak3918ev300(1), and the two unbuiltgk7102caprofiles.gk7205v200_rubyfpv_genericis left alone, since #262 deletes it.Upgrades.
customizer.shkeeps writing<device>-nor.tgzintoupgrade. sysupgrade turns that into<device>-nor-split.tgzwhen it exists, and the manifest resolver falls back tonor_split. The last fixed package already onlatest/nightlyis never deleted by this repo's CI, so a camera whose sysupgrade predates the layout installs that one first and then moves to the split package.CI: the workflow comments are reworded, which widens this PR to the full matrix.
ci-matrix.py --self-testandcheck-firmware-drift.py --self-testpass.Verified on
ssc338q_wfbng: a local build against #279's kernel, booted in qemu-bench-M ssc338qunder the published U-Boot, givessplit NOR layout, kernel 0x50000-0x250000, rootfs 0x250000-0xa60000, mounts the split rootfs and reaches login.