Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on #6255 over at MacPython/openblas-libs#293.
My AI agent and I noticed a very noisy build log on the win-arm64 build, which is being caused by
-Wall. This becomes-Weverythingon clang-cl (absolutely everything), rather than/W3(problematic warnings only), emitting lots of warnings. It can also be spelled/clang:-Wallif you want.We also saw that compilation of
dllinit.cwas weird. Because the CMake file usesVERBATIM, the flags were being added as a single string of compound arguments (and ignored) rather than as separate arguments. In my build this shows up in the logs asSo dllinit.c compiles with none of those defines or flags — it gets one bogus -W… argument instead. Harmless today (dllinit.c is a bare DllMain), but it silently drops -DMS_ABI, -DMAX_CPU_NUMBER, CRT and optimization flags from that one object.
If you want I can remove the verbose comments from the changes