Repository navigation
Keep SQL usage endpoints whose names differ only in case - #6153
Open
warwickschroeder wants to merge 1 commit into
Open
warwickschroeder wants to merge 1 commit into
warwickschroeder wants to merge 1 commit into
Conversation
warwickschroeder
requested review from
PhilBastian,
abparticular,
johnsimons and
rbev
November 18, 2026 03:57
rbev
approved these changes
Nov 18, 2026
johnsimons
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Throughput is stored per source: the broker, audit and monitoring each save their own licensing endpoint row under the name they see.
Audit and monitoring report the endpoint name as configured, such as
Sales.Billing, while some brokers report the queue in lower case,sales.billing, so one endpoint can arrive in two spellings.On SQL Server and PostgreSQL the throughput lookup matched those spellings case-insensitively and gave all the throughput to the first one, so the other read as empty, and reading the usage data (the ServicePulse Usage page, the usage report) deleted that row and all its throughput history. The SQL store now returns each spelling its own throughput, as RavenDB does, so nothing reads as empty and nothing is deleted.
#6146 moves that deletion into a daily background job that reads through the same lookup, so it needs this fix too.
docs/describes how throughput is matched by queue name (docs/README.md,throughput-collection.mdandusage-report.mdreviewed).Tests
ServiceControl.Persistence.Tests/Throughput/EndpointsTests.cs: three new shared store tests, run on SQL Server, PostgreSQL, RavenDB and InMemory, pin per-spelling results, an unrequested spelling left out, and one entry per endpoint.ServiceControl.Persistence.Tests/UsageSummaryTests.cs(new): reading the usage summary keeps both case-only spellings and their counts, on SQL Server, PostgreSQL and RavenDB.