Repository navigation
Keep the endpoints on messages re-imported by --import-failed-errors - #6154
Open
warwickschroeder wants to merge 2 commits into
Open
warwickschroeder wants to merge 2 commits into
warwickschroeder wants to merge 2 commits into
Conversation
rbev
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
ServiceControl.exe --import-failed-errorsruns in its own host, which never registered the enricher that turns a message'sNServiceBus.OriginatingEndpointandProcessingEndpointheaders into its sending and receiving endpoints.Re-imported messages were stored with no endpoints, and ServicePulse, which renders every failed-message row with its receiving endpoint, then showed no rows at all in All Failed Messages or the message's group.
The import host now registers that enricher, so a re-imported message is stored exactly as normal ingestion stores it.
docs/describes--import-failed-errorsor its host.Tests
ServiceControl.AcceptanceTests/Recoverability/MessageFailures/When_failed_error_imports_are_imported_again.cs(new): the real import host re-imports a failed import and stores both endpoints, with host ids, and records both as known endpoints, on RavenDB, SQL Server and PostgreSQL.