Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 293a6ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 293a6ae
💡 With Ultracache enabled, Nx Cloud learns each task's file inputs in CI and uses them on later runs. Turn on Ultracache in workspace settings ↗ · Read docs ↗ ☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/angular-devtools
@tanstack/devtools
@tanstack/devtools-a11y
@tanstack/devtools-bundler-core
@tanstack/devtools-client
@tanstack/devtools-rspack
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-webmcp
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/svelte-devtools
@tanstack/vue-devtools
commit: |
|
I'm not sure if this would impact the other libraries, did we actually confirm this does not cause issues? |
|
@AlemTuzlak I've tried the repo examples react/start react/time-travel, and "dependencies": {
"@tanstack/devtools-client": "https://pkg.pr.new/@tanstack/devtools-client@371",
"@tanstack/devtools-event-client": "https://pkg.pr.new/@tanstack/devtools-event-client@371",
"@tanstack/react-devtools": "https://pkg.pr.new/@tanstack/react-devtools@371",
"@tanstack/react-form": "^1.23.7",
"@tanstack/react-query": "^5.90.1",
"@tanstack/react-query-devtools": "^5.90.1",
"@tanstack/react-router": "^1.132.0",
"@tanstack/react-router-devtools": "^1.132.0",
"react": "^19.2.0",
"react-dom": "^19.2.0",
"zod": "^4.3.5"
},
"devDependencies": {
"@tanstack/devtools-ui": "https://pkg.pr.new/@tanstack/devtools-ui@371",
"@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
"@tanstack/react-form-devtools": "^0.1.7",
"@types/react": "^19.2.0",
"@types/react-dom": "^19.2.0",
"@vitejs/plugin-react": "^5.0.4",
"sonda": "0.9.0",
"vite": "^7.1.7",
"vite-plugin-inspect": "11.3.3"
},and that solid/basic can run wtih "dependencies": {
"@tanstack/solid-devtools": "https://pkg.pr.new/@tanstack/solid-devtools@371",
"@tanstack/solid-query": "^5.90.1",
"@tanstack/solid-query-devtools": "^5.90.1",
"@tanstack/solid-router": "^1.131.50",
"@tanstack/solid-router-devtools": "^1.131.50",
"solid-js": "^1.9.9"
},
"devDependencies": {
"@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
"vite": "^7.1.7",
"vite-plugin-inspect": "11.3.3",
"vite-plugin-solid": "^2.11.8"
},To do this, i remove the pnpm.overrides in the root package json, and set preferWorkspacePackages: false Is there something in particular that I can double check? |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
@AlemTuzlak , this would allow the us to gradually move things to solid2 |
This PR adjust where solid-js v1 appear in peerDeps and devDeps, because the current setup gets in the way of e.g. router-devtools-core upgrading to solid v2. PR here:
With this pr the devtools become compatible with e.g. router devtools of both solid v1 and solid v2
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact
Summary by CodeRabbit
solid-jsas a peer dependency when using the Devtools packages.