Skip to content

fix: adjust use of solid-js in peerDeps and devDeps - #371

Open
birkskyum wants to merge 8 commits into
TanStack:mainfrom
birkskyum:remove-solid-js-from-peer-deps
Open

birkskyum wants to merge 8 commits into
TanStack:mainfrom
birkskyum:remove-solid-js-from-peer-deps

Conversation

@birkskyum

@birkskyum birkskyum commented Mar 6, 2026 •

Copy link
Copy Markdown
Member

This PR adjust where solid-js v1 appear in peerDeps and devDeps, because the current setup gets in the way of e.g. router-devtools-core upgrading to solid v2. PR here:

With this pr the devtools become compatible with e.g. router devtools of both solid v1 and solid v2

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Compatibility
    • Removed the requirement for applications to declare solid-js as a peer dependency when using the Devtools packages.

@changeset-bot

changeset-bot Bot commented Mar 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 293a6ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@tanstack/devtools-ui Patch
@tanstack/devtools Patch
@tanstack/devtools-a11y Patch
@tanstack/angular-devtools Patch
@tanstack/preact-devtools Patch
@tanstack/react-devtools Patch
@tanstack/solid-devtools Patch
@tanstack/svelte-devtools Patch
@tanstack/vue-devtools Patch
@tanstack/devtools-example-angular-a11y-devtools Patch
@tanstack/devtools-example-angular-basic Patch
@tanstack/devtools-example-angular-panel Patch
@tanstack/devtools-example-angular-with-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud

nx-cloud Bot commented Mar 6, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 293a6ae

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 2m 49s View ↗
nx run-many --target=test:e2e --parallel=1 --pr... ✅ Succeeded 1m 16s View ↗
nx run-many --targets=build --exclude=examples/... ✅ Succeeded 37s View ↗

💡 With Ultracache enabled, Nx Cloud learns each task's file inputs in CI and uses them on later runs. Turn on Ultracache in workspace settings ↗ · Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-11-18 02:05:43 UTC

@pkg-pr-new

pkg-pr-new Bot commented Mar 6, 2026 •

Copy link
Copy Markdown
More templates

@tanstack/angular-devtools

npm i https://pkg.pr.new/@tanstack/angular-devtools@371

@tanstack/devtools

npm i https://pkg.pr.new/@tanstack/devtools@371

@tanstack/devtools-a11y

npm i https://pkg.pr.new/@tanstack/devtools-a11y@371

@tanstack/devtools-bundler-core

npm i https://pkg.pr.new/@tanstack/devtools-bundler-core@371

@tanstack/devtools-client

npm i https://pkg.pr.new/@tanstack/devtools-client@371

@tanstack/devtools-rspack

npm i https://pkg.pr.new/@tanstack/devtools-rspack@371

@tanstack/devtools-ui

npm i https://pkg.pr.new/@tanstack/devtools-ui@371

@tanstack/devtools-utils

npm i https://pkg.pr.new/@tanstack/devtools-utils@371

@tanstack/devtools-vite

npm i https://pkg.pr.new/@tanstack/devtools-vite@371

@tanstack/devtools-webmcp

npm i https://pkg.pr.new/@tanstack/devtools-webmcp@371

@tanstack/devtools-event-bus

npm i https://pkg.pr.new/@tanstack/devtools-event-bus@371

@tanstack/devtools-event-client

npm i https://pkg.pr.new/@tanstack/devtools-event-client@371

@tanstack/preact-devtools

npm i https://pkg.pr.new/@tanstack/preact-devtools@371

@tanstack/react-devtools

npm i https://pkg.pr.new/@tanstack/react-devtools@371

@tanstack/solid-devtools

npm i https://pkg.pr.new/@tanstack/solid-devtools@371

@tanstack/svelte-devtools

npm i https://pkg.pr.new/@tanstack/svelte-devtools@371

@tanstack/vue-devtools

npm i https://pkg.pr.new/@tanstack/vue-devtools@371

commit: 293a6ae

@birkskyum
birkskyum marked this pull request as draft March 6, 2026 21:23
@birkskyum
birkskyum marked this pull request as ready for review March 6, 2026 21:31
@AlemTuzlak

Copy link
Copy Markdown
Collaborator

I'm not sure if this would impact the other libraries, did we actually confirm this does not cause issues?

@birkskyum

birkskyum commented Mar 9, 2026 •

Copy link
Copy Markdown
Member Author

@AlemTuzlak I've tried the repo examples react/start react/time-travel, and basic for few frameworks. E.g. react/basic example can run with the pre-releases form this PR

  "dependencies": {
    "@tanstack/devtools-client": "https://pkg.pr.new/@tanstack/devtools-client@371",
    "@tanstack/devtools-event-client": "https://pkg.pr.new/@tanstack/devtools-event-client@371",
    "@tanstack/react-devtools": "https://pkg.pr.new/@tanstack/react-devtools@371",
    "@tanstack/react-form": "^1.23.7",
    "@tanstack/react-query": "^5.90.1",
    "@tanstack/react-query-devtools": "^5.90.1",
    "@tanstack/react-router": "^1.132.0",
    "@tanstack/react-router-devtools": "^1.132.0",
    "react": "^19.2.0",
    "react-dom": "^19.2.0",
    "zod": "^4.3.5"
  },
  "devDependencies": {
    "@tanstack/devtools-ui": "https://pkg.pr.new/@tanstack/devtools-ui@371",
    "@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
    "@tanstack/react-form-devtools": "^0.1.7",
    "@types/react": "^19.2.0",
    "@types/react-dom": "^19.2.0",
    "@vitejs/plugin-react": "^5.0.4",
    "sonda": "0.9.0",
    "vite": "^7.1.7",
    "vite-plugin-inspect": "11.3.3"
  },

and that solid/basic can run wtih

  "dependencies": {
    "@tanstack/solid-devtools": "https://pkg.pr.new/@tanstack/solid-devtools@371",
    "@tanstack/solid-query": "^5.90.1",
    "@tanstack/solid-query-devtools": "^5.90.1",
    "@tanstack/solid-router": "^1.131.50",
    "@tanstack/solid-router-devtools": "^1.131.50",
    "solid-js": "^1.9.9"
  },
  "devDependencies": {
    "@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
    "vite": "^7.1.7",
    "vite-plugin-inspect": "11.3.3",
    "vite-plugin-solid": "^2.11.8"
  },

To do this, i remove the pnpm.overrides in the root package json, and set preferWorkspacePackages: false

Is there something in particular that I can double check?

@birkskyum birkskyum changed the title Remove solid js from peer deps fix(devtools package): remove solid-js from peer deps Mar 9, 2026
@birkskyum birkskyum changed the title fix(devtools package): remove solid-js from peer deps fix: adjust use of solid-js in peerDeps and devDeps Mar 9, 2026
@ryansolid ryansolid mentioned this pull request Nov 13, 2026
2 of 5 tasks
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request removes Solid peer dependency declarations from @tanstack/devtools-ui and @tanstack/devtools. It adds solid-js as a development dependency of @tanstack/devtools-utils and records patch releases for the two packages.

Changes: Solid dependency contract

Layer / File(s) Summary
Package dependency updates
packages/devtools-ui/package.json, packages/devtools/package.json, packages/devtools-utils/package.json, .changeset/hip-readers-retire.md
The two devtools packages remove their solid-js peer dependency declarations. devtools-utils adds solid-js as a development dependency. The changeset declares patch releases and states that panels from Solid 1 or Solid 2 libraries can mount in the shell.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: alemtuzlak

Merge Risk: Minimal · up to 293a6

This PR changes how solid-js is declared in the devtools packages so the devtools can work alongside router devtools using either Solid v1 or v2. No concrete defect was found in the manifest changes. The Solid 2 panel compatibility claim in the changeset rests on router code outside this repository, so it is worth confirming with a real Solid 2 integration. It is not a blocker.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix: adjust use of solid-js in peerDeps and devDeps" matches the main change. The PR removes solid-js v1 peer dependency declarations from the devtools packages and adds a devDependency in …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The author explains the motivation: the solid-js v1 declarations in peerDependencies and devDependencies block router-devtools-core from upgrading to Solid v2. The PR links the related router change a…
Full details: Title check

Explanation

The title "fix: adjust use of solid-js in peerDeps and devDeps" matches the main change. The PR removes solid-js v1 peer dependency declarations from the devtools packages and adds a devDependency in devtools-utils, so the title describes the primary change. It names the files' dependency sections but does not describe the compatibility goal with Solid v2.

Full details: Description check

Explanation

The author explains the motivation: the solid-js v1 declarations in peerDependencies and devDependencies block router-devtools-core from upgrading to Solid v2. The PR links the related router change and states that the devtools will work with router devtools on both Solid v1 and v2. The Changes section is still the unedited template comment, so the PR does not describe the specific file-level changes. The checklist shows the changeset was generated and the release impact is marked. The local test item is not checked, and the author gave no test details for pnpm test:pr. The description covers the required intent and release impact, but it omits a concrete change list and the test status.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8f62544 and 293a6ae.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 4

  • .changeset/hip-readers-retire.md
  • packages/devtools-ui/package.json
  • packages/devtools-utils/package.json
  • packages/devtools/package.json
Files with no reviewable changes: 2

  • packages/devtools-ui/package.json
  • packages/devtools/package.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@birkskyum

Copy link
Copy Markdown
Member Author

@AlemTuzlak , this would allow the us to gradually move things to solid2

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants