Repository navigation
Conversation
svelte-package keeps relative import specifiers as written, so the published declarations imported './types' without an extension. Under NodeNext or Node16 resolution, TypeScript rejects that with TS2835 when skipLibCheck is off. With skipLibCheck on, the import silently fails and the TanStackDevtools props and the exported plugin types turn into any. Fixes TanStack#564
🦋 Changeset detectedLatest commit: 0e8da64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
🎯 Changes
svelte-packagekeeps the extensionless./typesspecifier, so undermoduleResolution: "NodeNext"or"Node16"the published declarations can't resolve it. WithskipLibCheck: falsethat's aTS2835. WithskipLibCheck: truethe component props and plugin types silently becomeany. This adds.jsto the three imports.Checked with the repro from the issue:
svelte-checknow reports the expected errors in both modes.Fixes #564
✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
any.