Repository navigation
Conversation
Contributor
Author
|
@AyanSinhaMahapatra @ziadhany Could you kindly take a look. |
ziadhany
requested changes
Nov 18, 2026
Comment on lines
+5
to
+7
| schedule: | ||
| # Run weekly | ||
| - cron: '0 0 * * 0' |
Member
There was a problem hiding this comment.
Should this run on push, not on a schedule? like https://github.com/aboutcode-org/dejacode/blob/main/.github/workflows/find-vulnerabilities.yml#L6
Contributor
Author
There was a problem hiding this comment.
- I didn't add on
pushsince we are running on pull requests. But I can add it and it should be good since its a quick test. - schedule will catch new advisories that we collect in between commits.
@ziadhany Let me know what your thoughts are :>
| - 'setup.cfg' | ||
| - 'requirements*.txt' | ||
| - 'pyproject.toml' | ||
| - '.github/workflows/find-vulnerabilities.yml' |
Member
There was a problem hiding this comment.
Why do we need to run the pipeline if we edit this pipeline?
Contributor
Author
There was a problem hiding this comment.
@ziadhany I added it to make it run on my fork and this PR initially. However I think we should keep it since we would want to run it again if we change this workflow anytime in future. That is why it is here. What are your thoughts?
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Samk1710
force-pushed
the
scancode-next_add_find_vulnerabilities_workflow
branch
from
November 18, 2026 16:30
6b8f8ed to
b341319
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
Workflow run on my Fork: https://github.com/Samk1710/vulnerablecode/actions/runs/43901988661
Refs used: