Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate invalid JSON from non-empty HTTP 200 POST responses instead of swallowing it and leaving
Connection.send_request()waiting indefinitely. The existing send-failure cleanup rejects the affected request; the connection can serve a subsequent valid response.Remove the broad suppression, add two request/recovery regressions, and document the error behavior. No schema, dependency or public-signature changes.
Related issues
Fixes #200.
Testing
Locked environment: CPython 3.12.16, Windows/amd64, httpx2 2.12.0.
tests/http/test_http_client.py— 15 passed. Tests use realConnection/HTTP transport code and the existing fake HTTP server.pytest --doctest-modules: 540 passed, 2 skipped, 1 failed. The failure is the existing Windows CRLF length assertion intest_spawn_stdio_transport_custom_limit_handles_large_line, reproduced on clean main4fed584.hypercornimports inexamples/http_server.py; both reproduce in the clean main worktree. No new diagnostics.Docs & screenshots
Added a note to the web-transport client documentation. No UI changes.
AI assistance: Codex found this during source review, prepared/reviewed the patch and ran the checks under the account holder's instruction. A production incident or independent human verification is not claimed.
Checklist