Repository navigation
feat(schema)!: bump ACP v1 schema to 1.33.0 - #202
Draft
raymondfeng wants to merge 2 commits into
Draft
raymondfeng wants to merge 2 commits into
raymondfeng wants to merge 2 commits into
Conversation
Regenerate the v1 bindings from schema-v1.33.0 (`make gen-all`). Builds on the stateless MCP-over-ACP binding, which 1.33 requires. - Pass the new session fields to the wire. The signature generator added them to the senders, but the hand-written bodies dropped them: `system_prompt` and `config_options` on new/load/resume/fork, `cursor_id` on fork, `archived` on list. Add a wire test, and a test that every sender uses all its parameters. - Add the methods 1.33 introduces, all unstable: `archive_session`, `unarchive_session`, `session_status`, `session_options`, `set_session_title`, `auth_status`, and the client notification `auth_status_update`. - Remove next edit suggestions and the document notifications, which the schema removed (agent-client-protocol db2116ef, #2266). - Name the 1.33 `PlanUpdateContent` variants by kind. The schema dropped the `file` variant, and the positional name map turned `markdown` into `PlanUpdateFile`. Drop the stale `NesSuggestion` map. - Move two tests off models the schema changed: `ToolCallLocation.line` for the default-on-error salvage, `StringPropertySchema.format` for inline literals. - Regenerate experimental v2 at its current pin (alpha.7) with the current generator. BREAKING CHANGE: the NES and document methods are gone (`start_nes`, `suggest_nes`, `close_nes`, `accept_nes`, `reject_nes`, `did_open`, `did_change`, `did_close`, `did_save`, `did_focus`), and so are their models. `PlanUpdateFile` is gone with the schema's `file` plan update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the v1 bindings from schema-v1.33.0 (
make gen-all). The SDK is on 1.23.0 today, sosystemPromptonsession/new(stable v1) cannot be sent.This builds on #193 by @xelandernt and should merge after it. 1.33 already uses the stateless MCP-over-ACP shape (
serverId+requestId, nomcp/connectormcp/disconnect), so a 1.33 bump needs #193. This branch carries #193's commit, rebased onmainwith its author kept. Only the second commit is new here. If #193 merges first, I will rebase so this PR shows only that commit.What the second commit does:
system_promptandconfig_optionstonew_session,load_session,resume_sessionandfork_session, pluscursor_idon fork andarchivedonlist_sessions. But the hand-written bodies never passed them to the request models, so they were silently dropped. New tests: a wire test thatsystem_promptreaches the agent, and an AST test that every sender uses all its parameters. Both fail when one sender's field is removed again.archive_session,unarchive_session,session_status,session_options,set_session_titleandauth_statuson the agent, and theauth_status_updatenotification on the client. Each has a round-trip test and a row in the quickstart table. The names followdelete_sessionandclose_session; happy to rename.db2116ef, "fix(unstable): remove next edit suggestions (#2266)").filevariant ofPlanUpdateContent, and the positionalvariant_model_mapthen named themarkdownvariantPlanUpdateFile. The map now reads("PlanUpdateItems", "PlanUpdateMarkdown"). Also drops the staleNesSuggestionmap, which removes the--model-name-mapwarnings.ToolCallLocation.linefor the default-on-error salvage (1.33 removed the marker fromReadTextFileRequest.line), andStringPropertySchema.formatfor inline literal values (it replacesSuggestNesRequest.trigger_kind).Breaking changes
start_nes,suggest_nes,close_nes,accept_nes,reject_nes,did_open,did_change,did_close,did_save,did_focus.PlanUpdateFileis gone with the schema'sfileplan update.mcp_messageandnotify_mcptakeserver_idandrequest_id, andconnect_mcpanddisconnect_mcpare removed.Testing
Each step of
make checkandmake test, run locally on Python 3.13:uv lock --locked: okruff check .andruff format --check .: cleanty check(same excludes as the Makefile): cleandeptry src: no issuespython -m pytest --doctest-modules: 611 passed, 1 skippedmake gen-check(scripts.gen_schema --check,scripts.gen_meta --check): cleanI also checked the change against the Claude Agent ACP adapter (0.108.0) and the Codex ACP adapter (2.7.0). With these bindings, a
systemPromptinappendoroverridemode reaches the agent. Before the body fix, it was dropped.Docs & screenshots
docs/quickstart.md: the method table lists the new methods and drops the NES and document rows. (The MCP-over-ACP docs come from #193.)Checklist
feat:,fix:).make gen-all) are called out if applicable.AI-assisted contribution by Claude Code (Claude Opus 5.5). Opened as a draft for my own review before it is marked ready.
🤖 Generated with Claude Code