Skip to content

feat(schema)!: bump ACP v1 schema to 1.33.0 - #202

Draft
raymondfeng wants to merge 2 commits into
agentclientprotocol:mainfrom
raymondfeng:feat/schema-1.33
Draft

raymondfeng wants to merge 2 commits into
agentclientprotocol:mainfrom
raymondfeng:feat/schema-1.33

Conversation

@raymondfeng

Copy link
Copy Markdown

Summary

Regenerates the v1 bindings from schema-v1.33.0 (make gen-all). The SDK is on 1.23.0 today, so systemPrompt on session/new (stable v1) cannot be sent.

This builds on #193 by @xelandernt and should merge after it. 1.33 already uses the stateless MCP-over-ACP shape (serverId + requestId, no mcp/connect or mcp/disconnect), so a 1.33 bump needs #193. This branch carries #193's commit, rebased on main with its author kept. Only the second commit is new here. If #193 merges first, I will rebase so this PR shows only that commit.

What the second commit does:

  • Passes the new session fields to the wire. The signature generator added system_prompt and config_options to new_session, load_session, resume_session and fork_session, plus cursor_id on fork and archived on list_sessions. But the hand-written bodies never passed them to the request models, so they were silently dropped. New tests: a wire test that system_prompt reaches the agent, and an AST test that every sender uses all its parameters. Both fail when one sender's field is removed again.
  • Adds the 1.33 methods, all unstable: archive_session, unarchive_session, session_status, session_options, set_session_title and auth_status on the agent, and the auth_status_update notification on the client. Each has a round-trip test and a row in the quickstart table. The names follow delete_session and close_session; happy to rename.
  • Removes next edit suggestions and the document notifications, which the schema removed (agent-client-protocol db2116ef, "fix(unstable): remove next edit suggestions (#2266)").
  • Fixes a naming regression in the generator config. 1.33 drops the file variant of PlanUpdateContent, and the positional variant_model_map then named the markdown variant PlanUpdateFile. The map now reads ("PlanUpdateItems", "PlanUpdateMarkdown"). Also drops the stale NesSuggestion map, which removes the --model-name-map warnings.
  • Moves two tests off models the schema changed: ToolCallLocation.line for the default-on-error salvage (1.33 removed the marker from ReadTextFileRequest.line), and StringPropertySchema.format for inline literal values (it replaces SuggestNesRequest.trigger_kind).
  • Regenerates experimental v2 at its current pin (alpha.7) with the current generator. This resolves the rebase conflict and keeps v2 out of scope.

Breaking changes

  • The NES and document methods and their models are gone: start_nes, suggest_nes, close_nes, accept_nes, reject_nes, did_open, did_change, did_close, did_save, did_focus.
  • PlanUpdateFile is gone with the schema's file plan update.
  • From feat(mcp)!: adopt stateless MCP-over-ACP binding #193: mcp_message and notify_mcp take server_id and request_id, and connect_mcp and disconnect_mcp are removed.

Testing

Each step of make check and make test, run locally on Python 3.13:

  • uv lock --locked: ok
  • ruff check . and ruff format --check .: clean
  • ty check (same excludes as the Makefile): clean
  • deptry src: no issues
  • python -m pytest --doctest-modules: 611 passed, 1 skipped
  • make gen-check (scripts.gen_schema --check, scripts.gen_meta --check): clean

I also checked the change against the Claude Agent ACP adapter (0.108.0) and the Codex ACP adapter (2.7.0). With these bindings, a systemPrompt in append or override mode reaches the agent. Before the body fix, it was dropped.

Docs & screenshots

docs/quickstart.md: the method table lists the new methods and drops the NES and document rows. (The MCP-over-ACP docs come from #193.)

Checklist

  • Conventional Commit title (e.g. feat:, fix:).
  • Tests cover the change or are not required (explain above).
  • Docs/examples updated when behaviour is user-facing.
  • Schema regenerations (make gen-all) are called out if applicable.

AI-assisted contribution by Claude Code (Claude Opus 5.5). Opened as a draft for my own review before it is marked ready.

🤖 Generated with Claude Code

xelandernt and others added 2 commits November 18, 2026 10:45
Regenerate the v1 bindings from schema-v1.33.0 (`make gen-all`). Builds on the
stateless MCP-over-ACP binding, which 1.33 requires.

- Pass the new session fields to the wire. The signature generator added them to
  the senders, but the hand-written bodies dropped them: `system_prompt` and
  `config_options` on new/load/resume/fork, `cursor_id` on fork, `archived` on
  list. Add a wire test, and a test that every sender uses all its parameters.
- Add the methods 1.33 introduces, all unstable: `archive_session`,
  `unarchive_session`, `session_status`, `session_options`, `set_session_title`,
  `auth_status`, and the client notification `auth_status_update`.
- Remove next edit suggestions and the document notifications, which the schema
  removed (agent-client-protocol db2116ef, #2266).
- Name the 1.33 `PlanUpdateContent` variants by kind. The schema dropped the
  `file` variant, and the positional name map turned `markdown` into
  `PlanUpdateFile`. Drop the stale `NesSuggestion` map.
- Move two tests off models the schema changed: `ToolCallLocation.line` for the
  default-on-error salvage, `StringPropertySchema.format` for inline literals.
- Regenerate experimental v2 at its current pin (alpha.7) with the current
  generator.

BREAKING CHANGE: the NES and document methods are gone (`start_nes`,
`suggest_nes`, `close_nes`, `accept_nes`, `reject_nes`, `did_open`, `did_change`,
`did_close`, `did_save`, `did_focus`), and so are their models.
`PlanUpdateFile` is gone with the schema's `file` plan update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants