Repository navigation
Conversation
Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a typo or an old setting makes
openshell-gateway config preflightfail, the error can now point you to the line to fix. For example, if the removedguest_tls_certsetting is still on line 5 ofgateway.tomlafter an upgrade, you'll seeunknown_field=guest_tls_cert line=5.Related Issue
Closes #5308. This also addresses the unknown-key error reported in #3959.
Changes
Release Notes
Testing
Eight focused
openshell-serverlibrary tests passed. They cover the preflight CLI and runtime behavior, including quoted keys, escaped characters, Unicode with CRLF line endings, and errors that point to the whole table. A separate caller compiled using the existing two-fieldConfigFileError::Parseconstructor.Server Clippy passed for all targets with warnings denied. Formatting and whitespace checks passed, along with the SPDX and changed Markdown checks.
mise run docspassed with three warnings and a passing navigation check. GitHub Branch Checks passed on0d13466.Checklist