Repository navigation
Conversation
…ories A dependency on an extra of another package from the wheel METADATA, e.g. coverage[toml], used the [toml] target of the hub, which only exists if the lock file requests the extra, and failed the build otherwise. The extras that a package provides are only known from its METADATA, so the whl repository of the dependency resolves them: the dependent package uses an extra_dep target that points to the _extras target of the dependency, which is forwarded by the hub. The missing_extra_error rule is no longer needed. Work towards bazel-contrib#2786
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dependency on an extra of another package from the wheel METADATA,
e.g.
pytest-covrequiringcoverage[toml], used the[toml]targetof the hub, which only exists if the lock file requests the extra, and
the build failed otherwise. The whl repositories now create an
extra_deptarget for such an edge and an_extrastarget that selectsthe extra, and the hub only forwards
_extras. This also works withouta hub. An extra that is not provided only prints a warning, like
pip,so the
missing_extra_errorrule is removed.Part of #41. Based on the previous PR of the stack.
Work towards bazel-contrib#2786