Repository navigation
Conversation
The dependencies that are not in the hub are left out, which is only correct if no target platform needs them. With the marker environments of the target platforms passed as envs, deps() now also returns such dependencies as missing if their markers can be true on any of them. Nothing passes the envs yet, so there is no behaviour change. Work towards bazel-contrib#2786
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies from the METADATA that are not in the hub are left
out, which is only correct if no target platform needs them. With the
marker environments of the target platforms passed as
envs, thepep508
depsfunction now also returns such dependencies asmissingif their markers can be true on any of them. Nothing passes
envsyet,so there is no behaviour change.
Part of #41. Based on the previous PR of the stack.
Work towards bazel-contrib#2786