Repository navigation
Conversation
The dependencies from the wheel METADATA that are not in the hub are left out, which is only correct if they are not needed on any of the target platforms, e.g. when the lock file is compiled for Python 3.12 and the hub is also used with Python 3.10. The whl repositories now load the marker environments of the target platforms from the hub and print a warning that names the package, the missing dependency and its marker. The warnings about the dependencies of an extra are only printed if the extra is used, i.e. it is requested in the hub or another package depends on it through its extra_select target. Work towards bazel-contrib#2786
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lock file that is compiled for fewer platforms or Python versions
than the hub is used with silently drops dependencies, e.g.
tomliforcoverage[toml]on Python 3.10. The whl repositories now loadtarget_platform_envsfrom the hub and print a warning that names thepackage, the missing dependency and its marker if it can be needed on
any target platform. The warnings for an extra are only printed when
the extra is used: at loading time if the hub requests it, otherwise by
the
extra_selecttarget when another package depends on it.Part of #41. Based on the previous PR of the stack.
Work towards bazel-contrib#2786