Repository navigation
fix(i18n): add English messages for three backend error reasons - #1672
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
reason.AnswerRestrictAnswer, reason.UploadFileSourceUnsupported and reason.ErrFeatureDisabled point to keys that are missing from i18n/en_US.yaml, so the API returned the raw key as the error message.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
backend.error.answer.restrict_answer,backend.error.upload.source_unsupportedandbackend.error.feature.disabledtoi18n/en_US.yaml.reason.AnswerRestrictAnswer(returned byAnswerController.Addininternal/controller/answer_controller.gowhen "restrict answer" is on and the user already has an answer on the question),reason.UploadFileSourceUnsupported(internal/controller/upload_controller.go) andreason.ErrFeatureDisabled(FeatureToggleService.EnsureEnabled). They are not inen_US.yaml(orzh_CN.yaml), sotranslator.Trfalls back to the key and the response message is the raw key, e.g.error.answer.restrict_answer.How I checked: compared every string constant in
internal/base/reason/reason.gowith thebackendsection ofen_US.yaml; these three were the only ones missing. The edited file parses as YAML and the three keys resolve. I did not run the server locally.Prepared with the help of an AI assistant.