Repository navigation
Write Parquet page indexes by default - #4402
Open
Anurag-S1ngh wants to merge 7 commits into
Open
Anurag-S1ngh wants to merge 7 commits into
Anurag-S1ngh wants to merge 7 commits into
Conversation
Readers that support page indexes can skip non-matching pages during predicate evaluation, but PyIceberg never wrote them. Add the write.parquet.page-index-enabled table property, off by default so the current output and file sizes are preserved, and pass it to the Parquet writer.
Fokko
reviewed
Nov 17, 2026
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Two things:
- I'm not sure if we need this property. It is very specific, and Java doesn't have it either.
- Java writes the indexes by default, so I feel like we should also do that in PyIceberg
This was referenced Nov 17, 2026
Contributor
Author
|
Yes, my mistake, I have checked. I've flipped the default so PyIceberg writes the column and offset indexes by default too, matching Java. I kept |
Fokko
reviewed
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyIceberg never wrote Parquet page indexes, so readers that support them cannot skip non-matching pages during predicate evaluation. PyArrow already supports this with
ParquetWriter(write_page_index=True), and the Java writer writes these indexes by default, so PyIceberg now does the same.Changes
write.parquet.page-index-enabledtable property, defaulttrue, as an opt-out.Testing
false, and checkshas_column_indexandhas_offset_indexon the resulting row group.Closes #3847