Repository navigation
Row lineage: Read _last_updated_sequence_number - #4413
Open
rambleraptor wants to merge 2 commits into
Open
rambleraptor wants to merge 2 commits into
rambleraptor wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Thanks @rambleraptor! Inheriting from the data sequence number, and the nulls for files without a first_row_id, match the spec. I left one suggestion inline about REST-planned scans.
A couple of smaller suggestions:
- The new
first_row_id: int64line inapi.mdis in theinspect.entries()example; I think it belongs withfiles. - Since this adds
first_row_idtoinspect.files()and makes_last_updated_sequence_numberreadable, it may be worth adding the changelog label.
Carry the data sequence number of each data file on FileScanTask, and fill null _last_updated_sequence_number values with it, as the Java readers do. The value is null when the file has no first row ID or no data sequence number, such as for files planned by a REST server. Part of apache#4080.
Add the first_row_id column to the files metadata tables, matching the Java files table schema. Part of apache#4080.
rambleraptor
force-pushed
the
row-lineage-read-seq-number
branch
from
November 18, 2026 21:20
f823088 to
0cdeab5
Compare
Collaborator
Author
|
@rahulsmahadev thanks so much for your review! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I can break this up into a couple separate PRs, but I wanted to finish up row lineage.
This does two things:
Are these changes tested?
Included unit test + updated our Spark test (from the last PR)
Are there any user-facing changes?