Repository navigation
Conversation
Agents had no instruction to validate behavior against the spec, or to fall back to the Java implementation where the spec is ambiguous.
rambleraptor
approved these changes
Nov 18, 2026
|
|
||
| ### Spec Compliance | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> |
Collaborator
There was a problem hiding this comment.
Any reason for disabling the Markdown link checker?
rambleraptor
approved these changes
Nov 18, 2026
| ### Spec Compliance | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> | ||
| - The [Iceberg spec](https://github.com/apache/iceberg/blob/main/format/spec.md) is the source of truth. Check changes to metadata, manifests, schemas, partitioning, transforms, or the commit path against it, and cite the relevant section when behavior is non-obvious. |
Collaborator
There was a problem hiding this comment.
We could potentially make that list larger (include work involving the catalogs?) and maybe even just tell the agents to always look at the Java reference implementation for any changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Agents had no instruction to validate behavior against the spec, or to fall back to the Java implementation where the spec is ambiguous.
Are these changes tested?
Are there any user-facing changes?