Repository navigation
fix(common): preserve AWS_SDK_UA_APP_ID environment variable in UserAgentConfigurator - #2762
Open
dhaiirryyaa wants to merge 1 commit into
Open
dhaiirryyaa wants to merge 1 commit into
dhaiirryyaa wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Changes
When a customer sets the
AWS_SDK_UA_APP_IDenvironment variable in their Lambda environment (rather than setting thesdk.ua.appIdJava system property directly),UserAgentConfiguratorpreviously ignored it and set only the Powertools user agentPT/{FEATURE}/{VERSION} PTENV/{ENV}, which overwrote and hid the customer's configured user agent app ID.This change preserves the user's custom user agent by:
AWS_SDK_UA_APP_IDenvironment variable if thesdk.ua.appIdsystem property is unset or empty.UserAgentConfiguratorTestverifying both environment variable preservation and that system property still takes precedence over the environment variable when both are set.This aligns behavior with
powertools-lambda-typescript(PR #4374).Issue number: Fixes #2725
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.