Repository navigation
fix(logging): do not lower verbosity from TRACE to DEBUG during log sampling - #2763
Open
dhaiirryyaa wants to merge 1 commit into
Open
dhaiirryyaa wants to merge 1 commit into
dhaiirryyaa wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Changes
Log sampling exists to make sampled invocations more verbose (e.g.
INFO/WARN→DEBUG).Previously,
PowertoolsLogging.setLogLevelBasedOnSamplingRateunconditionally calledloggingManager.setLogLevel(Level.DEBUG)whenever an invocation was sampled.If the logger was already configured at a higher verbosity than
DEBUG(such asPOWERTOOLS_LOG_LEVEL=TRACE), sampling inadvertently demoted the log level toDEBUG, disablingTRACEon the very invocations selected for detailed diagnosis.This change:
!LOG.isTraceEnabled()before setting the log level toDEBUG, ensuring sampling only increases verbosity and never reduces it.powertools-lambda-typescript(PR #2902).PowertoolsLoggingTest:TRACEwhenPOWERTOOLS_LOG_LEVEL=TRACE.INFOtoDEBUGas expected.Issue number: Fixes #2726
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.