Repository navigation
Conversation
Collaborator
Author
|
This PR was written by an AI coding agent (Claude Code) working under the direction of @aignas, who reviewed the design and the changes. Review comments will be handled by @aignas, possibly with the help of the agent; any agent-drafted replies or follow-up commits are reviewed by @aignas before being posted. An agent monitors CI only to retry flaky network failures. This comment was generated by an AI agent and reviewed by the user. |
aignas
marked this pull request as draft
November 20, 2026 01:42
aignas
changed the base branch from
main
to
refactor.aignas.missing-package-error
November 22, 2026 05:28
aignas
force-pushed
the
feat.aignas.extras-helpers
branch
from
November 22, 2026 05:40
0860532 to
e3b34cc
Compare
aignas
changed the base branch from
refactor.aignas.missing-package-error
to
main
November 22, 2026 05:40
…helpers # Conflicts: # python/private/pypi/BUILD.bazel
7 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the helpers that are needed for creating a target per extra of a
package, split out from #4490 to make the review easier:
strip_extrasremoves the extras from a requirement line, so that thesame distribution requested with different extras can be handled
together.
pep508_deps.depsgainskeep_extras, which returns the dependencieson the extras of other packages as separate nodes, e.g.
foo[bar]andfoo[baz]forfoo[bar,baz]. Theexcludesnow match these nodes,so that a single extra of a package can be excluded, and the self
edges are dropped by name.
extra_labelreturns the target name of an extra, e.g.[bar], andgroup_membernormalizes a member of a requirement cycle group, e.g.Foo[Bar]tofoo[bar].There are no user-facing changes.
Work towards #2786