Repository navigation
Split out the cold portion of bundles when we get fixed-constraint conflicts in cold code - #279
Merged
Merged
Conversation
cfallin
reviewed
Nov 17, 2026
cfallin
left a comment
Member
There was a problem hiding this comment.
Thanks!
Idea below re: by-construction ensuring this invariant (rather than splitting after the fact) might help the compilation time impact -- curious what you think given all your experimentation. Happy to consider this approach still if it doesn't work.
cfallin
approved these changes
Nov 17, 2026
cfallin
left a comment
Member
There was a problem hiding this comment.
OK, this version looks good -- happy to merge once the merge conflict is resolved and once the dense/sparse (vec/hashset) question on cold_blocks is tested. Thanks!
… code We do not count this towards the bundle's attempts since a bundle can only be split into hot and cold portions once, and each new sub-bundle is homogenous forever after.
fitzgen
enabled auto-merge (squash)
November 17, 2026 18:43
fitzgen
added a commit
to fitzgen/wasmtime
that referenced
this pull request
Nov 17, 2026
…ytecodealliance#15329) They already inherited coldness from their successor, but this commit makes them also inherit it from their predecessor. If either is cold, then that implies that the critical-edge block is also cold. This improves code quality by better falling though hot paths and better register allocation after bytecodealliance/regalloc2#279 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit for details. Benchmark results below.
tests/disas/component-model/compile-time-builtins-x64.watWasmtime's Compile-Time Builtins Criterion Benchmarks
Sightglass
This is instructions retired. Cycles was a lot noisier, even on a 200 iteration run, but generally looked similar enough.
TLDR:
Details