Repository navigation
Conversation
Fixes diffplug#3159 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3159.
shortenFullyQualifiedTypesonly looked at type nodes and expression scopes, so@com.fasterxml.jackson.annotation.JsonCreatorwas never shortened. Annotation names are always types, so the step now shortens them with the same safety rules as other references (no change when the simple name clashes with a declared/imported/unqualified name, or inside types with unknown inheritance). Unqualified annotation names are now also counted as in-use simple names so a same-package annotation can't be shadowed by a new import.Test plan:
issue3159_annotationsShortened(marker, single-member, normal and parameter annotations) fails before the change and passes after.annotationNotShortenedWhenSimpleNameClashes../gradlew spotlessCheck :testlib:test --tests '*ShortenFullyQualifiedTypesStepTest'passes.AI disclosure: this change was written with AI assistance (Claude) and verified by running the tests above.
🤖 Generated with Claude Code