Skip to content

docs: say swarm drain does not wait for replacement tasks - #25871

Open
locker95 wants to merge 1 commit into
docker:mainfrom
locker95:docs/drain-no-wait-replicas
Open

locker95 wants to merge 1 commit into
docker:mainfrom
locker95:docs/drain-no-wait-replicas

Conversation

@locker95

Copy link
Copy Markdown
Contributor

The drain tutorial says the manager stops tasks on the node and launches replicas on an active node. That's true, but it doesn't wait for those replacements to be running first — so you can dip under --replicas, and draining the last worker takes everything down at once.

Added that to the existing note.

@netlify /engine/swarm/swarm-tutorial/drain-node/

Fixes #9917

@locker95
locker95 requested a review from dvdksn as a code owner August 17, 2026 13:56
@github-actions github-actions Bot added area/engine Issue affects Docker engine/daemon area/swarm Issue affects swarm and clustering functionality of docker labels Aug 17, 2026
@netlify

netlify Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ad1ecc2
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6afd5323bfdb805adf0f70fe
😎 Deploy Preview https://deploy-preview-25871--docsdocker.netlify.app/engine/swarm/swarm-tutorial/drain-node/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR. We'd like to make our product docs better, but haven't been able to review all the suggestions. As our docs change often and quickly diverge, we do not have the bandwidth to review and rebase old PRs.

If the updates are still relevant, please rebase your PR against the latest version of the docs and add a comment when it's ready. This helps our maintainers focus on active contributions. If there's no activity, this PR will be closed in 30 days.

To remove the stale label: Comment /lifecycle active
To freeze (requires write access): Comment /lifecycle frozen

Signed-off-by: Dean Chen <862469039@qq.com>
@locker95
locker95 force-pushed the docs/drain-no-wait-replicas branch from 466fc33 to ad1ecc2 Compare November 18, 2026 07:26
@locker95

Copy link
Copy Markdown
Contributor Author

rebased on main, still relevant.

/lifecycle active

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon area/swarm Issue affects swarm and clustering functionality of docker lifecycle/stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clearly explain that draining a swarm node does not wait for replcas to be started on an active node before stopping tasks on a node being drained

1 participant