Repository navigation
fix: set elapsed property in MockTransport responses - #3843
Open
shrimanasa wants to merge 1 commit into
Open
shrimanasa wants to merge 1 commit into
shrimanasa wants to merge 1 commit into
Conversation
MockTransport did not set the property on responses, causing a RuntimeError when users accessed in tests using MockTransport. Both sync and async handlers now record the time taken to invoke the handler and set response.elapsed accordingly, matching the behaviour of real transports. If the handler already sets elapsed manually, it is left untouched. Closes encode#3712
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3712
MockTransportdid not set theelapsedproperty on responses, causing aRuntimeErrorwhen users accessedresponse.elapsedin tests.Changes
Both
handle_requestandhandle_async_requestnow:response.elapsedas adatetime.timedeltaafter the handler returnsIf the handler already sets
elapsedmanually, it is preserved (the fix only sets it when_elapsedis not already present).Example
Before this fix:
After this fix: