Repository navigation
.github: Always use the SDK from version.txt for main - #4393
Merged
Merged
Conversation
I recently added an override for this, but it's annoying when main is broken for long periods, so always use version.txt in that case. I've kept the override in case we need it for the other channels at some point. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/gha-main-sdk
branch
from
November 20, 2026 10:19
6a99e61 to
3aa0fe2
Compare
tormath1
approved these changes
Nov 20, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The SDK version is updated before its container is published, causing main update jobs to fail until publication and remain blocked if the build fails because no fallback is available.
1 open issue
1 resolved since last review
Review effort: Balanced
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I recently added an override for this in #4355, but it's annoying when main is broken for long periods, so always use version.txt in that case. I've kept the override in case we need it for the other channels at some point.
Testing done
None, the change is fairly trivial.