Skip to content

.github: Always use the SDK from version.txt for main - #4393

Merged
chewi merged 1 commit into
mainfrom
chewi/gha-main-sdk
Nov 20, 2026
Merged

chewi merged 1 commit into
mainfrom
chewi/gha-main-sdk

Conversation

@chewi

@chewi chewi commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

I recently added an override for this in #4355, but it's annoying when main is broken for long periods, so always use version.txt in that case. I've kept the override in case we need it for the other channels at some point.

Testing done

None, the change is fairly trivial.

@chewi chewi self-assigned this Nov 20, 2026
@chewi
chewi requested a review from a team as a code owner November 20, 2026 10:15
Copilot AI balanced review requested due to automatic review settings November 20, 2026 10:15

This comment was marked as resolved.

I recently added an override for this, but it's annoying when main is
broken for long periods, so always use version.txt in that case. I've
kept the override in case we need it for the other channels at some
point.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@chewi
chewi force-pushed the chewi/gha-main-sdk branch from 6a99e61 to 3aa0fe2 Compare November 20, 2026 10:19
Copilot AI balanced review requested due to automatic review settings November 20, 2026 10:19
@chewi
chewi merged commit 20a5d3c into main Nov 20, 2026
2 of 3 checks passed
@chewi
chewi deleted the chewi/gha-main-sdk branch November 20, 2026 10:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The SDK version is updated before its container is published, causing main update jobs to fail until publication and remain blocked if the build fails because no fallback is available.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread .github/workflows/setup-flatcar-sdk.sh Resolved

This branch is waiting to be deployed

1 waiting deployment
development — 3aa0fe28 Waiting Nov 20, 2026 by chewi via Wait for approval #6165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants