Skip to content

Send screen and view analytics for VM Tools and DTD Tools - #10095

Merged
keertip merged 2 commits into
flutter:masterfrom
keertip:vm-dtd-tools-analytics
Nov 17, 2026
Merged

keertip merged 2 commits into
flutter:masterfrom
keertip:vm-dtd-tools-analytics

Conversation

@keertip

@keertip keertip commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Every other DevTools screen calls ga.screen() when its body is created, but the VM Tools and DTD Tools screens did not, so we have no usage numbers for these screens.

This PR:

  • Sends ga.screen(gac.dtdTools) when the DTD Tools screen opens (DTDToolsScreenBody is now stateful).
  • Sends ga.screen(gac.vmTools) when the VM Tools screen opens (VMDeveloperToolsScreenBody is now stateful).
  • For VM Tools sub-views, follows the AnalyticsTabbedView pattern: a non-interaction ga.select for the view that's visible on open, and a ga.select when the user picks a different view in the navigation rail.
  • Adds a VmToolsEvents enum (vmStatistics, isolateStatistics, objectInspector, processMemory, queuedMicrotasks) and a gaEvent field on VMDeveloperView, plus a gac.dtdTools screen id.

No UI or behavior change. Tests: no new tests. Other screens' ga.screen calls aren't covered by tests, and analytics are stubbed in widget tests.

@keertip
keertip requested review from a team and bkonyi as code owners November 17, 2026 19:39
@keertip
keertip requested review from srawlins and removed request for a team November 17, 2026 19:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates analytics tracking across several DevTools screens, including the DTD tools and various VM developer tools. It updates the VMDeveloperView base class to require a gaEvent and converts DTDToolsScreenBody and VMDeveloperToolsScreenBody to StatefulWidget instances to facilitate proper analytics initialization and tracking of screen and selection events. I have no feedback to provide as there were no review comments.

@keertip
keertip merged commit 87e46d0 into flutter:master Nov 17, 2026
51 of 52 checks passed
@keertip
keertip deleted the vm-dtd-tools-analytics branch November 17, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants