Repository navigation
Send screen and view analytics for VM Tools and DTD Tools - #10095
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates analytics tracking across several DevTools screens, including the DTD tools and various VM developer tools. It updates the VMDeveloperView base class to require a gaEvent and converts DTDToolsScreenBody and VMDeveloperToolsScreenBody to StatefulWidget instances to facilitate proper analytics initialization and tracking of screen and selection events. I have no feedback to provide as there were no review comments.
srawlins
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other DevTools screen calls
ga.screen()when its body is created, but the VM Tools and DTD Tools screens did not, so we have no usage numbers for these screens.This PR:
ga.screen(gac.dtdTools)when the DTD Tools screen opens (DTDToolsScreenBodyis now stateful).ga.screen(gac.vmTools)when the VM Tools screen opens (VMDeveloperToolsScreenBodyis now stateful).AnalyticsTabbedViewpattern: a non-interactionga.selectfor the view that's visible on open, and aga.selectwhen the user picks a different view in the navigation rail.VmToolsEventsenum (vmStatistics,isolateStatistics,objectInspector,processMemory,queuedMicrotasks) and agaEventfield onVMDeveloperView, plus agac.dtdToolsscreen id.No UI or behavior change. Tests: no new tests. Other screens'
ga.screencalls aren't covered by tests, and analytics are stubbed in widget tests.