Skip to content

Standardize MISRA audit and strict tags - #1223

Open
mbaluda wants to merge 1 commit into
mainfrom
mbaluda/standardize-misra-audit-tags
Open

mbaluda wants to merge 1 commit into
mainfrom
mbaluda/standardize-misra-audit-tags

Conversation

@mbaluda

@mbaluda mbaluda commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Description

MISRA C queries and suites used different spellings for audit and strict tags. This PR standardizes on external/misra/audit and external/misra/strict so the default suites do not pick up opt-in queries and the dedicated suites do not miss them.

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • None
  • Queries have been modified for the following rules:
    • DIR-5-3
    • RULE-2-8

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 18, 2026 16:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The cross-suite CodeQL metadata and MISRA tag changes require human confirmation of suite membership, resolver behavior, and package/schema validation because those runtime checks were not independently executable.

No open issues 🎉

What changed in this PR

Standardizes MISRA C audit and strict tags so default, advisory, audit, and strict suites select the intended queries consistently, without changing query logic. The required change note and related metadata updates are included.

Changes:

  • Replaces legacy MISRA C audit and strict tags with external/misra/audit and external/misra/strict.
  • Updates MISRA C audit and advisory suite filters.
  • Updates the rule-package schema and metadata.
File Description
schemas/​rule-package.schema.json Defines support for the standardized MISRA strict tag.
rule_packages/​c/​DeadCode2.json Updates the strict RULE-2-8 query metadata to use the standardized tag.
rule_packages/​c/​Concurrency6.json Updates the DIR-5-3 audit query metadata to use the standardized tag.
change_notes/​2026-11-18-standardize-misra-suite-tags.md Documents the MISRA suite-membership and tag changes.
c/​misra/​src/​rules/​RULE-2-8/​UnusedObjectDefinitionStrict.ql Applies the standardized strict tag to the query.
c/​misra/​src/​rules/​DIR-5-3/​BannedDynamicThreadCreation.ql Applies the standardized audit tag to the query.
c/​misra/​src/​codeql-suites/​misra-c-audit.qls Selects queries using the standardized audit tag.
c/​misra/​src/​codeql-suites/​misra-c-advisory.qls Excludes audit and strict-tagged queries from the advisory suite.

Review effort: Lite (adaptive)

@mbaluda
mbaluda requested a review from a team November 18, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants