Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The cross-suite CodeQL metadata and MISRA tag changes require human confirmation of suite membership, resolver behavior, and package/schema validation because those runtime checks were not independently executable.
No open issues 🎉
What changed in this PR
Standardizes MISRA C audit and strict tags so default, advisory, audit, and strict suites select the intended queries consistently, without changing query logic. The required change note and related metadata updates are included.
Changes:
- Replaces legacy MISRA C audit and strict tags with
external/misra/auditandexternal/misra/strict. - Updates MISRA C audit and advisory suite filters.
- Updates the rule-package schema and metadata.
| File | Description |
|---|---|
| schemas/rule-package.schema.json | Defines support for the standardized MISRA strict tag. |
| rule_packages/c/DeadCode2.json | Updates the strict RULE-2-8 query metadata to use the standardized tag. |
| rule_packages/c/Concurrency6.json | Updates the DIR-5-3 audit query metadata to use the standardized tag. |
| change_notes/2026-11-18-standardize-misra-suite-tags.md | Documents the MISRA suite-membership and tag changes. |
| c/misra/src/rules/RULE-2-8/UnusedObjectDefinitionStrict.ql | Applies the standardized strict tag to the query. |
| c/misra/src/rules/DIR-5-3/BannedDynamicThreadCreation.ql | Applies the standardized audit tag to the query. |
| c/misra/src/codeql-suites/misra-c-audit.qls | Selects queries using the standardized audit tag. |
| c/misra/src/codeql-suites/misra-c-advisory.qls | Excludes audit and strict-tagged queries from the advisory suite. |
Review effort: Lite (adaptive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MISRA C queries and suites used different spellings for audit and strict tags. This PR standardizes on
external/misra/auditandexternal/misra/strictso the default suites do not pick up opt-in queries and the dedicated suites do not miss them.Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
DIR-5-3RULE-2-8Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.