Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
15 of 29 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Initializer matching relies on source locations and argument order, which can suppress tentative definitions across translation units and falsely flag compliant macro-based initialized declarations.
2 open issues
What changed in this PR
Adds MISRA C:2025 Rule 8.18 detection for tentative file-scope definitions in headers, building on the edition infrastructure from #1216.
Changes:
- Adds the query, rule metadata, exclusion registration, and implementation status.
- Adds fixtures covering declarations, initializers, macros, redeclarations, and translation-unit differences.
- Extends release-tool testing to exclude the new rule from older editions.
| File | Description |
|---|---|
scripts/release/create_supported_rules_list_test.py |
Checks that Rule 8.18 does not appear in older editions. |
rules-misra-c-2025.csv |
Marks Rule 8.18 as implemented. |
rule_packages/c/Declarations5.json |
Defines query metadata and implementation scope. |
cpp/common/src/codingstandards/cpp/exclusions/c/Declarations5.qll |
Registers the query for exclusions. |
c/misra/test/rules/RULE-8-18/test.c |
Adds source-file and local-variable controls. |
c/misra/test/rules/RULE-8-18/sample.h |
Covers header declarations, redeclarations, and macros. |
c/misra/test/rules/RULE-8-18/other.c |
Provides cross-translation-unit test cases. |
c/misra/test/rules/RULE-8-18/DefinitionsInHeader.qlref |
Connects fixtures to the production query. |
c/misra/test/rules/RULE-8-18/DefinitionsInHeader.expected |
Records expected alerts. |
c/misra/test/rules/RULE-8-18/conditional.h |
Tests conditionally initialized declarations. |
c/misra/src/rules/RULE-8-18/DefinitionsInHeader.ql |
Implements tentative-definition detection in included files. |
Review effort: Balanced (adaptive)
| this.isDefinition() and | ||
| initializer = this.getVariable().getInitializer() and | ||
| ( | ||
| initializer.getLocation().subsumes(this.getLocation()) |
| initializer.getLocation().subsumes(this.getLocation()) | ||
| or | ||
| // Initializers follow their own declarators, not definitions in other translation units. | ||
| this.getLocation().isBefore(initializer.getLocation(), _) and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Implement MISRA C:2025 Rule 8.18 by reporting tentative file-scope definitions in headers.
The query and relative tests cover extern and initialized declarations, static objects, redeclarations, macros, and source-file and local controls.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.