Skip to content

Bump msw from 2.15.0 to 3.0.4 in /extensions/ql-vscode - #4650

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/msw-3.0.3
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/msw-3.0.3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Bumps msw from 2.15.0 to 3.0.4.

Release notes

Sourced from msw's releases.

v3.0.4 (2026-11-06)

Bug Fixes

  • worker: prevent the worker from going idle (#2830) (6dd13026f08c1c85a9eb4fdbb3b5c59d0f2c079e) @​kettanaito
  • isCommonAssetRequest: add ico to common assets (#2829) (ebffbd4c7f5be0d4db625ed10812d58f82ed92d7) @​kettanaito

v3.0.3 (2026-10-10)

Bug Fixes

  • HandlersController: dispose of reset handlers (#2810) (3818a81c455a638eda1558558d8ae3cd17a34e55) @​kettanaito
  • expose network context on enable in network sources (#2809) (d1fe8e6e6e7eefce43746ee44802bc553731e951) @​kettanaito

v3.0.2 (2026-10-03)

Bug Fixes

  • vite: support virtual:msw imports in vitest (#2802) (e73c381e3adc0848fcf9a7ef291b614b06a0d92b) @​kettanaito

v3.0.1 (2026-09-30)

Bug Fixes

  • treat CONNECT requests as the transport mechanism (#2796) (7cad86a03b0ddb2efdec96ce8a49b0ed07d9f4dc) @​kettanaito

v3.0.0 (2026-09-28)

⚠️ BREAKING CHANGES

  • MSW is now ESM-only (#2765).
  • Deprecate support for Node.js v18 and v20 (#2729). The minimal supported Node.js version is v22.
  • msw/native is removed in favor of @msw/react-native.
  • Require TypeScript 5.9 as the minimal version.
  • Deprecate support for TypeScript 5.1 and 5.2 (#2730)
  • worker.stop() returns a Promise (#2724). Awaiting it is relevant only for in-flight critical scenarios.
  • graphql is now exported as msw/graphql (#2691). GraphQL is now handled as a proper optional peer dependency.
  • Removes the handleRequest() utility. Please use the defineNetwork() API instead.
  • GraphQLLinkHandlers type has been renamed to GraphQLLink.
  • The file:// requests now throw in Node.js as they normally do (not supported by fetch).
  • The Content-Length request header is now removed by bypass().
  • HTTP-to-WebSocket upgrade requests performed via fetch() now throw in Node.js as they normally do (not supported by fetch).
  • Cookies are no longer managed in Node.js for better compatibility. Instead, whatever is the default behavior of your environment that's the cookie behavior you get. This has no effect on the browser.
  • WebSocket connection life cycle event has been renamed to websocket:connection (#2783).
  • onUnhandledRequest option has been renamed to onUnhandledFrame.
  • The library no longer patches setTimeout to circumvent fake timers in test runners. You should advance the fake timers normally for delayed mocked responses to resolve.
  • The library no longer returns a mocked cookie string on request.headers.get('cookie') in the handlers. It returns null in all environments. Please use the cookies resolver argument to have cookie-based logic.

... (truncated)

Commits
  • 9bbfe99 chore(release): v3.0.4
  • 6dd1302 fix(worker): prevent the worker from going idle (#2830)
  • ebffbd4 fix(isCommonAssetRequest): add ico to common assets (#2829)
  • 28c74aa chore: fix the typescript-nightly job to run (#2819)
  • 3560a94 chore(release): v3.0.3
  • 3818a81 fix(HandlersController): dispose of reset handlers (#2810)
  • d1fe8e6 fix: expose network context on enable in network sources (#2809)
  • 22a4626 test(node): add jsdom cors/preflight regression tests (#2808)
  • a32ee31 docs: add beehiiv to partners (#2805)
  • 501a591 chore: update github social image
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
msw [>= 1.a, < 2]

@dependabot
dependabot Bot requested a review from a team as a code owner November 12, 2026 10:15
@dependabot dependabot Bot added the Update dependencies Dependabot update PRs label Nov 12, 2026
Copilot AI adaptive review requested due to automatic review settings November 12, 2026 10:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The MSW 3 bump leaves Jest unable to load its ESM modules and retains the renamed onUnhandledRequest option, breaking affected tests and leaving unhandled-request policies unmigrated.

2 open issues
1 file not reviewed
  • extensions/ql-vscode/package-lock.json: Generated file
What changed in this PR

Updates MSW, used for GitHub API mocking and tests in the CodeQL VS Code extension, from 2.15.0 to 3.0.3.

Changes:

  • Raises the MSW dependency range to ^3.0.3.
  • Refreshes the lockfile for MSW 3 and its transitive dependencies, including updated runtime and peer requirements.
File Description
extensions/​ql-vscode/​package.json Updates the declared MSW dependency.
extensions/​ql-vscode/​package-lock.json Locks MSW 3.0.3 and updates its dependency tree.

Review effort: Balanced (auto)

Comment thread extensions/ql-vscode/package.json Outdated
"js-yaml": "^5.4.2",
"koffi": "^3.3.2",
"msw": "^2.15.0",
"msw": "^3.0.3",
Comment thread extensions/ql-vscode/package.json Outdated
"js-yaml": "^5.4.2",
"koffi": "^3.3.2",
"msw": "^2.15.0",
"msw": "^3.0.3",
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/msw-3.0.3 branch from 1b8e137 to 7a984ae Compare November 12, 2026 10:51
@kaspersv
kaspersv requested an adaptive review from Copilot November 12, 2026 10:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The MSW 3 upgrade leaves removed APIs in use and lacks Jest ESM transformation support, causing type-checking failures, ignored request-handling options, and test module-loading failures.

3 open issues
1 file not reviewed
  • extensions/ql-vscode/package-lock.json: Generated file

Review effort: Balanced (auto)

Comment thread extensions/ql-vscode/package-lock.json Outdated
"resolved": "https://registry.npmjs.org/msw/-/msw-2.15.0.tgz",
"integrity": "sha512-2wQAmKkQKxRuXvYJxVhPGG0wZNBQyD06oJvxqw90XqLvptdqxdlHrFUfEteKkpaNORX3Xzc+HtEl/q0nfmN2wQ==",
"hasInstallScript": true,
"version": "3.0.3",
Bumps [msw](https://github.com/mswjs/msw) from 2.15.0 to 3.0.4.
- [Release notes](https://github.com/mswjs/msw/releases)
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md)
- [Commits](mswjs/msw@v2.15.0...v3.0.4)

---
updated-dependencies:
- dependency-name: msw
  dependency-version: 3.0.3
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Bump msw from 2.15.0 to 3.0.3 in /extensions/ql-vscode Bump msw from 2.15.0 to 3.0.4 in /extensions/ql-vscode Nov 13, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/msw-3.0.3 branch from 7a984ae to cbbc5c9 Compare November 13, 2026 08:16
@codeql-ci-app

codeql-ci-app Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Dependabot automation

Retrying failed jobs once before Copilot investigation. If CI passes, this pristine PR remains eligible for automatic merging.

Automation run

@github-actions github-actions Bot added the dependency-needs-review Dependabot automation state; remove only deliberately label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependabot automation

Diagnosis: The msw 2.15.0 → 3.0.4 upgrade breaks more than the API types. In Build Extension attempt 2, Build (Ubuntu), Test (Ubuntu), and CLI Test on Ubuntu and Windows fail during compilation: UnhandledRequestStrategy and onUnhandledRequest no longer match MSW’s API. Lint reports the same errors plus three integration-test call sites. Unit Test (Ubuntu) fails because Jest cannot parse MSW’s ESM. The other Windows build, test, and unit-test jobs were cancelled; the integration and CLI tests were not reached in the failing build jobs.

MSW’s v3 release notes confirm the rename to onUnhandledFrame and the switch to ESM-only. The checkout’s Node 22.21.1 and TypeScript 5.9.3 meet MSW 3.0.4’s declared minimums. However, the locked @mswjs/interceptors 0.45.11 also loads a WASM file relative to import.meta.url. The extension’s CommonJS bundle turns that value into undefined and does not copy this WASM asset. A local npx gulp compileEsbuild succeeded, but loading the resulting bundle with a VS Code API stub failed with TypeError: Invalid URL. Thus merely fixing the types and Jest transforms would leave an extension startup failure. The necessary bundling and packaging work involves gulpfile.ts, outside the permitted repair paths.

Local verification: On the unchanged checkout, npm run check-types failed with the CI type errors, and npm run test:unit -- --runInBand gh-api-client.test.ts reproduced the ESM failure. A temporary API rename made type checking pass, but adding the existing Jest transforms exposed a further import.meta parsing failure; exploratory source edits were removed. Windows and CodeQL integration tests were not run locally. Web search was unavailable; the versioned upstream release notes and source linked above were fetched directly.

Maintainer action: Either defer the major upgrade or undertake a coordinated migration: preserve bypass/error behavior with the new API, address Jest’s ESM handling, and choose a bundling approach that gives the interceptor a valid WASM URL and includes the asset in the packaged extension. Verify extension activation, interception and recording, then run the Linux and Windows integration and CLI suites. Human review and merge are required; CI was not retried.

Automatic merging is blocked pending a maintainer decision.

Automation run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-needs-review Dependabot automation state; remove only deliberately Update dependencies Dependabot update PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant