Skip to content

fix(notifications): treat offline as a connection state, not an error - #3706

Open
setchy wants to merge 2 commits into
mainfrom
feat/connection-status-offline
Open

setchy wants to merge 2 commits into
mainfrom
feat/connection-status-offline

Conversation

@setchy

@setchy setchy commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

A paused notification query means there is no connectivity, not that a fetch failed. This adds an explicit offline status so the tray and notifications view stop presenting the offline-to-online transition as an error.

  • Status gains offline; deriveStatus returns it when the query is paused.
  • The notifications view renders the existing OFFLINE Oops for offline.
  • The tray only maps error to the -1/red sentinel, so a paused query no longer flashes red.

Test plan

  • pnpm test for the affected suites
  • pnpm check
  • pnpm lint:check

A paused notification query means there is no connectivity, not that a fetch failed. Derive an explicit offline status so the tray and notifications view do not present the offline/reconnect transition as an error.
@github-actions github-actions Bot added the bug Something isn't working label Nov 17, 2026
@setchy
setchy marked this pull request as ready for review November 18, 2026 06:04
@setchy
setchy requested a review from afonsojramos as a code owner November 18, 2026 06:05
Name the device-level online flag separately from the paused-query presentation state, and document why the notifications view checks both.
@setchy
setchy marked this pull request as draft November 18, 2026 06:16
@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy marked this pull request as ready for review November 18, 2026 06:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

1 participant