Repository navigation
Conversation
A paused notification query means there is no connectivity, not that a fetch failed. Derive an explicit offline status so the tray and notifications view do not present the offline/reconnect transition as an error.
Name the device-level online flag separately from the paused-query presentation state, and document why the notifications view checks both.
setchy
marked this pull request as draft
November 18, 2026 06:16
|
setchy
marked this pull request as ready for review
November 18, 2026 06:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
A paused notification query means there is no connectivity, not that a fetch failed. This adds an explicit
offlinestatus so the tray and notifications view stop presenting the offline-to-online transition as an error.Statusgainsoffline;deriveStatusreturns it when the query is paused.Oopsforoffline.errorto the-1/red sentinel, so a paused query no longer flashes red.Test plan
pnpm testfor the affected suitespnpm checkpnpm lint:check