Repository navigation
Conversation
…tive mode Catch KeyboardInterrupt and EOFError in interactive CLI prompts and active generation turns to prevent unhandled traceback dumps and ensure clean exit.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
hi, this PR fixes ctrl+c and ctrl+d handling in adk run interactive mode so it exits cleanly without traceback dumps and lets users cancel a running turn safely. added tests as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli.py (interactive mode) pressing ctrl+c or ctrl+d would spit out raw python traceback rather than gracefully exiting
and while the agent was busy formulating its reply, hitting ctrl+c killed the entire CLI rather than canceling the turn and returning to prompt
the changes made by this PR address:
unit tests were added for ctrl+c and ctrl+d cases
Issue:
in interactive mode (cli.py), using ctrl+c or ctrl+d gives raw python traceback instead of quitting properly. in addition, while an agent is responding, use of ctrl+c
quits the whole process and doesn’t allow for the cancellation of the current turn but goes back to the prompt. in single query mode, ctrl+c quits without quitting
with exit code 130.
Solution: