Repository navigation
docs: clarify ports in the local example - #100
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the documentation-only port clarification.
No open issues 🎉
What changed in this PR
Clarifies the ports used by the existing local example. This is a documentation-only change; runtime code and GitHub workflows remain unchanged.
Changes:
- Specifies port
8936for readiness checks and port8935for discovery and forwarding.
| File | Description |
|---|---|
| README.md | Makes the local example’s metrics and request ports explicit. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the metrics and request ports used by the existing local example.
Only
README.mdchanges. Runtime code and GitHub workflows are unchanged.This small documentation change exercises the existing pull request checks and, after a separately approved merge, the normal main-branch CI and image publication. Keep this PR in draft for now; no merge or manual workflow dispatch is included.
Validation: checked the wording against the commands and configuration already documented in the README. Existing CI results will appear on this PR.