Repository navigation
1.6.0: the fixes of the issue review of 2026-11-21 - #19
Merged
Merged
Conversation
commands/list gives each cleanup the scope of its plan (project for the project's build, shared for the shared cache) and its danger level, so a view places a cleanup beside what it acts on and invents no grouping of its own (design 2026-11-21, F4; #13).
Inside `app = { ... }` under [targets] the rules layer offers the keys of
[targets.app], less those the inline table has, and an enum key's values;
a dependency's inline table is its specification, whose keys the schema
does not list, and gets nothing. A key is offered only after `{` or `,`.
The new answers are where mcpp-vscode 0.9 answered nothing; they are kept
in golden/inline-tables.json, apart from 0.9's goldens, which every other
position still equals (design 2026-11-21, F6; #15).
Inside a dependency's `features = [...]` the rules layer offers the features its own manifest declares and the edge does not name yet, a hover names the dependency, the default and what a feature implies, and a name the manifest does not declare is mcpp.manifest.unknownFeature, at the severity of unknownKey. The manifest is the one `path` names, or for workspace = true the one the nearest workspace's [workspace.dependencies] names; a dependency that declares no [features] accepts any name, as mcpp does. An index package's features are not answered: mcpp states none, and capabilities/explain names mcpp#992, which asks for them (design 2026-11-21, F7; #16, #17).
…th #
The mcpp-toml language had no configuration, so VS Code paired nothing
in mcpp.toml and Toggle Line Comment did nothing. It gets one: [ ] and { }
as brackets, quotes that close outside a string or a comment, # as the line
comment. The parity gate keeps every field of each language 0.9.0
contributed and admits an added one (design 2026-11-21, F8; #15, #18).
"Read access is allowed from inside read-action only" was logged at startup and each time a backend started: McppDocuments.reopen() read the open documents from the startup activity and from the thread that reads the backend's output, where every listener ran. That thread now only decodes frames: notifications reach their listeners in order on one pooled thread, answers complete on the pool, and reopen() takes its snapshot of the open documents in a read action (design 2026-11-21, F1; #13).
Opening a graph without the JCEF plugin failed with NoClassDefFoundError: the dependency on com.intellij.modules.jcef is optional, but JcefPage, a class of the core, linked to JCEF's classes, and its guard, JBCefApp.isSupported(), was the call that failed. The core now knows a page host (ui/PageHost.kt); JCEF's (ui/jcef) is registered only by mcpp-jcef.xml, which the platform reads when the JCEF plugin is loaded. Without a host, or with JCEF switched off, the tab says why (design 2026-11-21, F2; #13).
…ad when shown The cache tab drew every cleanup as one identical icon in its toolbar, with no grouping. It now has the two sections of VS Code's page, Project cache (target/) and Global build cache, each with its cleanups as links on its row and in its context menu, placed by the scope commands/list states; an ellipsis marks one that asks first, and the toolbar keeps Refresh. Two commands of one plan are one action. Toolbar texts and the Libraries button are read when shown, since the views are built before the session's strings arrive: the English tooltip beside Chinese rows. A test holds JCEF's classes to ui/jcef (design 2026-11-21, F3 and F5; #13).
The real-IDE runs already fail on an error the IDE logs, but none reached the paths of #13. PackagedPluginTest restarts the backend with mcpp.toml open and checks that the document is sent again, and checks the cache tab's sections. GraphInteractionTest runs with the JCEF plugin disabled beside the run with JCEF switched off. A job runs the startup chain and the graphs on macOS aarch64, where the report came from, and a weekly run checks the latest published plugin on the stable CLions (design 2026-11-21, F0).
:Mcpp showCachePanel shows the two sections CLion's cache tab and VS Code's page have, Project cache (target/) and Global build cache, each with the subcommands of its cleanups, placed by the scope commands/list states, one per plan (design 2026-11-21, "The cache view"; #13).
…elog Every component is 1.6.0. The CLion plugin depends on mcppls's CLion plugin 0.23.0, its latest release. CHANGELOG.md lists the fixes of the review of 2026-11-21; the CLion README names the runs added (design 2026-11-21, F9).
The record of the issue review of 2026-11-21: the surfaces a feature reaches a user by, the feature matrix every plugin is held to, Zed and Helix, the fixes of #13, #15 to #18 as one pull request per repository, and the plan of the work. Stream F is implemented here; its last section states where the implementation differs. Local reviews stay out of the repository (.agents/reviews/).
…iew's cases
The features of a dependency are every name mcpp registers: the keys of
[features], default among them, and the names of [feature-deps.<name>] and,
under a target selector, of feature-deps, feature-requires-abi and
feature-xlings; an empty [features] declares none, so any name is accepted,
as mcpp does. A suggestion between two elements brings its commas, an array
left open is read on its own line only, a multi-line element is not
reported, and one answer reads each manifest once. Inside an inline table the
keys written after the cursor are not offered again, and app = { ... } under
[targets] or [profile] is not an unknown key: mcpp reads it as [targets.app].
capabilities/explain says that mcpp states no features of an index package,
without naming a capability no release has.
…s order With answers completed on the pool and notifications on their own thread, a listener registered when an answer arrived (a job's end, a new project) could miss the notification that followed it, and a run's buffered output could be replayed after later lines. Both now run on one sequential thread, in the order the backend wrote them. The page's explanation is set on the EDT, a browser whose query cannot be made is disposed, and the weekly run reads the newest published release that carries the plugin.
CLion 2026.1 carries JCEF in its core (lib/intellij.libraries.jcef.jar), so no installation of it lacks JCEF and the run with the plugin disabled is skipped there, saying why; 2026.2 has the plugin, built per system, and the run holds on Linux x86_64 and macOS aarch64. The macOS job keeps the JUnit results, which name a failed assertion's message.
…he project's frame On macOS aarch64 the driver's mcpp.build was refused as disabled: the action is enabled for a session that knows the project's root, and the driver reads the data context of the focused window, which a macOS runner need not give the IDE. The run waits for the root and invokes the action on the project's frame, and a refusal names the root, the commands and the frame.
…s frame The build now ran on macOS aarch64, and the next action, a graph, was refused the same way: the driver read the focused window's data context. Each action of the run goes to the project's frame.
… one it was read from The kept build database was dropped when the watcher next polled the manifest (every 500 ms), so a graph asked within that time was the old manifest's, and the page, which is not redrawn on manifest/changed, kept it. The real-IDE graph run met it about one time in two, on 1.5.0 as on this series. An entry now records the manifest's time from before mcpp read it and is used only while the manifest has that time.
On macOS aarch64 one of the three graph runs, never the same one, started an IDE whose driver never connected; each followed another IDE's run, and the driver reaches every IDE on the same fixed ports. A run now starts when they are free, and the macOS job keeps the IDE's log.
On macOS aarch64 the second or the third IDE started on one runner could stop at its start, before any plugin loads (its log ends at "CPU cores"), and its driver never connected; which run met it changed from one run to the next. Each of the three graph runs now has its runner.
…logs The graph run on Linux x86_64 passed its seven checks and then failed on an error the IDE logged, which only the packaged-plugin run kept; neither the graph nor the settings run said what it was. Each now records the error's types and frames (no message, no path) before it fails, and both jobs keep them.
On macOS aarch64 an IDE stopped at its start one run in three, on a runner of its own too: its log ends at "CPU cores", before any plugin loads, and its driver never connected. Such a run starts a new IDE once and records that it did; a run whose IDE started is never repeated. The macOS job keeps the IDE's thread dumps for the stop itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fixes of the issue review of 2026-11-21, series 1.6.0, as the design record
.agents/docs/2026-11-21-editor-surfaces-and-feature-matrix.md(stream F) plans them: one pull request,each fix a commit of its own. Addresses #13, #15, #16, #17 and #18; the parts that are not this
project's are listed under Triage.
startup and on a backend's start); no class of the core names JCEF's, so a CLion without the JCEF
plugin explains instead of failing with
NoClassDefFoundError; the cache tab in the two sections ofVS Code's page with their cleanups; texts read when shown; the real-IDE runs that would have caught
these (a restart with
mcpp.tomlopen, the JCEF plugin disabled, macOS aarch64, a weekly run);mcppls's CLion plugin 0.23.0.
mcpp.toml's language configuration (pairs,#comments); the parity gatekeeps every field of 0.9.0's languages and admits additions.
pathorworkspace dependency, with completion, hover and
mcpp.manifest.unknownFeature(功能增强:添加features显示功能 #16, Feature request: Display package features and support checkbox toggle for selecting features #17);scopeand
levelon the cache commands ofcommands/list..agents/reviews/ignored.Found in review and by the IDE runs, and fixed here:
(a listener registered on an answer could miss the notification that followed it).
default,feature-deps, the targettables); suggestions bring their commas; an array left open is read on its own line; keys after the
cursor are not offered again;
app = { ... }under[targets]is not an unknown key (mcpp builds it).within the watcher's 500 ms after a manifest change was the old manifest's; the real-IDE run met it
about one run in two, on 1.5.0 too.
ports are free; CLion 2026.1, whose JCEF is in its core, skips the run with the JCEF plugin disabled.
Triage
std.pcmoverwritten: mcpp's, which writes the compilation database. No workaround.mcpp searchor a query of one package) mcpp#992 asks for them, andcapabilities/explainnames it. Apathor workspace dependency's are read from its own manifest.scope) is the backend's; the plugins change only how answers are shown.
Criteria
tests/cts/rules.cpp: 0.9's goldens at every other position,golden/inline-tables.json, targeted casestests/e2e/protocol.cppover a path and a workspace dependency;tests/cts/rules.cpp;tests/e2e/probe.cppforcapabilities/explaintests/e2e/protocol.cpp, checked against the protocol schemaBackendTest.theReadingThreadRunsNoListener; the real-IDE restart withmcpp.tomlopenUiTest.noClassOutsideUiJcefNamesJcef;GraphInteractionTest.graphExplainsAbsentJcefPluginUiTest.aToolbarsTextIsReadWhenItIsShown,UiTest.theCacheInTheSectionsOfVsCodesPage;PackagedPluginTesttest/toml/languageConfiguration.test.ts, the parity gatetests/smoke.luaReal IDEs: CI runs CLion 2026.1.5.2 and 2026.2.4.1 on Linux x86_64 and 2026.2.4.1 on macOS aarch64;
locally (Linux x86_64, Xvfb) CLion 2026.2.3 and 2026.2.4.1 passed
PackagedPluginTest(33 checks, therestart with
mcpp.tomlopen and the cache sections included) and the three graph runs, and the VS Codee2e suite passed in VS Code 1.91.0.
Local, Linux x86_64:
mcpp build && mcpp test(14 passed),check-sources,check-i18n,gen vscodewith no diff,test_changes.sh,npm test,gradle test buildPlugin verifyPlugin(Compatible with 2026.1 and 2026.2.3), the Neovim smoke test. The real-IDE runs and the e2e jobs are
left to CI.
Compatibility
commands/listaddsscopeandlevelto a cache command.mcpp.manifest.unknownFeature, at the severity ofmcpp.toml.diagnostics.unknownKey.mcpp-tomlgainsconfiguration.Checklist
X.Y.Z: <sentence>.docs/rules.md, the CLion README),spec/i18nand CHANGELOG.md follow the behaviour.spec/is edited, not its output;mcpp-ide-dev gen vscodeleaves no diff.