Repository navigation
1.7.0: mcpp-zed, the backend as a language server of mcpp.toml in Zed, made for Zed's registry - #22
Closed
Sunrisepeak wants to merge 4 commits into
Closed
Sunrisepeak wants to merge 4 commits into
Sunrisepeak wants to merge 4 commits into
Conversation
… Zed, made for Zed's registry mide-plugins/zed is a Zed extension, mcpp-ide-language-server (mcpp IDE), version 1.6.0: the backend of its own series as a language server of TOML, which answers completion, hover and diagnostics of mcpp.toml. It starts the command lsp.mcpp-ide.binary names, else the bundle of v1.6.0, downloaded once into its work directory from GitHub or the GitCode mirror; not a mcpp-ide from PATH, whose series it cannot check. It starts with a worktree's first TOML file, since declining elsewhere is shown as a failure in Zed's status bar and the backend reads only mcpp.toml and build.mcpp. It meets Zed's registry: the -language-server id, its license in its own directory, Rust 1.90 for wasm32-wasip2. CI's zed component tests it, builds it so and runs the registry's checks of the manifest and the license. extension.toml is the series' seventh statement, zed-vX.Y.Z tags a patch, and its README states the registry's rules and how a person submits it there. Closes #21.
…th its arguments alone
…ry component The review of #22 found that the extension sends editor "zed", which protocol.schema.json did not allow; AGENTS.md §7 asks the schema to change with the behaviour, and the schema is a backend path, so the Zed extension begins a series. Every component is 1.7.0 and the extension downloads v1.7.0. Also from the review: Cargo.lock is held to extension.toml by release-plan.sh like Cargo.toml; a marker written after the bundle is checked says it is whole, so a download cut short is repeated; the README says that a backend named in the settings is started as it is, and that the GitCode fallback has a release once its files are mirrored.
Member
After review
Rerun locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
What
mide-plugins/zedis mcpp-zed 1.6.0: a Zed extension (mcpp-ide-language-server, listed as mcpp IDE). It starts the backend of series 1.6 as a language server of TOML, which answers completion, hover and diagnostics ofmcpp.tomlto the editorzed. The backend is unchanged: it already serves an unnamed editor over standard LSP, so no series begins.lsp.mcpp-ide.binarynames. Otherwise it downloadsmcpp-ide-1.6.0-openkal-bundle-all.tar.gzofv1.6.0once into its work directory, from GitHub, else from GitCode'sxlings-res/mcpp-ide. It starts this system's runner on this architecture's image. It never starts amcpp-idefrom PATH: the extension cannot read the series a backend answers, so it could not refuse a backend of another series.mcpp.tomlat its root was measured to show "Failed to run mcpp-ide" in the status bar of every TOML project, and it would also miss projects below the root. The backend readsmcpp.tomlandbuild.mcpponly, so a worktree without one shows nothing.trusted: true: Zed starts no language server in a worktree it does not trust (measured, below).-language-serversuffix the registry asks of an extension that only provides a language server.mide-plugins/zed/LICENSEis Apache-2.0; the registry reads the extension's own directory.wasm32-wasip2with Rust 1.90, the registry's toolchain.components.tsvgainszed, andtest_changes.shcovers it.zedjob runscargo test, builds forwasm32-wasip2withZED_RUST_VERSION(versions.env), and runs.github/scripts/check-zed-extension.sh. That script makes the registry's checks of the manifest and the license, and it fails on a bad id, on a name containing "extension", and on a missing license.extension.tomlis the seventh statement.release-plan.shreads it, holdsCargo.tomlto it (PLUGIN_VERSIONis the crate's version), puts zed intovX.Y.0, and acceptszed-vX.Y.Z.release.ymltakeszed-v*tags; the release carries no file of its own, because Zed's registry builds the tagged commit.### zed 1.6.0, and the design record ("Zed, as implemented").What ran
cargo test --locked: 8 passed. They cover the settings over the release, the series' tag and asset, the GitCode URL, each platform's runner and image, the unsupported platforms, the errors and the initialization options.cargo build --locked --release --target wasm32-wasip2with Rust 1.90: no warning.mide-plugins/zed/LICENSE;validateManifestandvalidateExtensionsTomlpass;zed-extensionCLI, at the SHA its CI pins, packages the directory (provides: ["language-servers"]).release-plan.sh:v1.6.0gives every component, zed included;zed-v1.6.0givescomponents=zed;zed-v1.7.1is refused;Cargo.tomldiffering fromextension.tomlis refused.test_changes.sh,check-sourcesandcheck-i18npass.zed), Linux x86_64, under Xvfb with lavapipe. The packaged extension was unpacked underextensions/installed/mcpp-ide-language-serveras the registry installs it; PATH was/usr/bin:/bin; Zed's TOML extension was installed byauto_install_extensions.mcpp-ide-1.6.0into its work directory and Zed started the runner on the image, still running 20 s later.lsp.mcpp-ide.binarywith["serve"]:Zed 1.29.3with{"editor": "zed", "trusted": true};didOpenofmcpp.tomlcame with languagetoml;mcpp-ide 1.6.0and publishedmcpp.manifest.unknownKey("unknown key colour in [package]").arguments, the wrapper was started with none: Zed itself starts a command named there, so the README says to includeserve.cargo testcovers.