Skip to content

test: case 860 holds the members' build programs under way together by their steps - #1000

Merged
Sunrisepeak merged 2 commits into
mainfrom
fix/graph-860-concurrent-programs
Nov 22, 2026
Merged

Sunrisepeak merged 2 commits into
mainfrom
fix/graph-860-concurrent-programs

Conversation

@Sunrisepeak

@Sunrisepeak Sunrisepeak commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Case workspace/graph/860 asserted that at -j 4 at least two members' build programs compile at the same time. In run 44959494484 (macOS, three processors) it failed and passed on a re-run: each compile waits for its own unit's scan, the scans of the same file took 0.19, 1.65 and 2.75 s, and the compiles (0.7 to 0.9 s each) fell one after another. Whether compiles overlap follows from the scans' times; what the build graph holds is that the members' build programs advance together in one graph, and the scans of all three members began within 35 ms of the graph's start.

  • A: at -j 4, steps of at least two members (scan, compile, resource, link: obj/<m>-…, res/<m>-…, bin/<m>-… of the build programs' .ninja_log) are under way at one instant; each member's compile is recorded.
  • B: at -j 1, one member at a time (stronger than one compile at a time).
  • A step is an edge: the log's rows of one command share its hash and times, and an edge is a member's when every file it writes is that member's. The edge that deploys the C++ runtime's DLLs beside each member's program on Windows writes into all three members and is no member's step (counted by row it made -j 1 read as three members at once, run 44988440716).
  • C is unchanged.
  • The design record (2026-11-20, finding 19) states the measurements and the change.

Test-only; the engine is unchanged.

…y their steps, not by when their compiles fall
…e deployment written for every member is no member's
@Sunrisepeak
Sunrisepeak merged commit b9b6386 into main Nov 22, 2026
53 checks passed
@Sunrisepeak
Sunrisepeak deleted the fix/graph-860-concurrent-programs branch November 22, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant