Repository navigation
ci: the release gate verifies the upstream tag with the job's token, as ci.yml does - #9
Merged
Merged
Conversation
…as ci.yml does check_release.py runs import_upstream.py --verify-tag, which reads the GitHub API with GITHUB_TOKEN when it is set. release.yml did not set it, so the call shared the runner's per-address quota and mwrap-b10069.2's release was refused twice with "HTTP Error 403: rate limit exceeded".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
release.yml, the step "Verify immutable upstream release mapping" runstools/check_release.py, which runstools/import_upstream.py --verify-tag. That script reads the GitHub API withGITHUB_TOKENwhen the variable is set.ci.ymlsets it for the same command;release.ymldid not.Without the token the call used the runner's shared per-address quota. The release of
mwrap-b10069.2(run 45017316991) was refused twice withHTTP Error 403: rate limit exceeded.This PR sets
GITHUB_TOKENfor that step. The tagmwrap-b10069.2is not moved: its Release job is re-run, and from now on releases read the API with the job's token.