Repository navigation
Work around an MSVC 19.52 bug in the generated invocation functions - #116
Merged
Merged
Conversation
- Moved the generated function of each signature from a lambda variable template inside signature_traits_impl to a namespace-scope variable template, because MSVC 19.52 fails to convert the lambda to a function pointer from the second specialization of a member variable template on when its parameters expand the enclosing class template's pack (C2440). The member variable template now copies the closure, so each specialization keeps its own closure type and the call sites are unchanged. - Replaced signature_traits_impl::pointer_type with erased_ptr_t so the namespace-scope variable template can name the erased pointer type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developercommunity.visualstudio.com/t/Member-variable-template-initialized-by-/11182704