Skip to content

Allow finishing a queued engine command that never started - #1224

Closed
YiheHuang wants to merge 1 commit into
niklasf:masterfrom
YiheHuang:fix/1116-minimal
Closed

YiheHuang wants to merge 1 commit into
niklasf:masterfrom
YiheHuang:fix/1116-minimal

Conversation

@YiheHuang

Copy link
Copy Markdown

Summary

A queued engine command that never started could not be marked finished: set_finished() asserted that the state was ACTIVE or CANCELLING, and it unconditionally set the finished future. Allow the NEW state and only set the future once.

This also carries the three-line CI pin from #1222 so the Python 3.8/3.9 Ubuntu jobs can run; once #1222 is merged, that hunk disappears from this PR.

Fixes #1116.

@YiheHuang YiheHuang closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError is thrown if async analysis is cancelled too soon

1 participant