Skip to content

Document how info lines are aggregated in InfoDict - #1225

Open
saisriramlanke wants to merge 1 commit into
niklasf:masterfrom
saisriramlanke:document-info-aggregation
Open

saisriramlanke wants to merge 1 commit into
niklasf:masterfrom
saisriramlanke:document-info-aggregation

Conversation

@saisriramlanke

Copy link
Copy Markdown

Addresses #1165.

InfoDict says the information is aggregated, but it does not say how. Each info line only updates the keys it contains, so the dictionary holds the latest value of every key. Values can come from different lines, and "string" keeps only the last "info string" message.

This adds a paragraph to the InfoDict docstring that explains this and points to analysis() for reading each line.

I checked it with a small fake UCI engine that sends two "info string" lines and then a depth 2 line without a pv. analyse() returned only the second string, and depth 2 with the pv from depth 1.

@saisriramlanke

Copy link
Copy Markdown
Author

The failing checks come from master, not from this change. Commit 6e58bd4 uses chess.STATUS_VARIANT in chess/variant.py and in test_empty_side, but it is not defined in chess/init.py, so the test and typing jobs fail on master too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant