Repository navigation
Document how info lines are aggregated in InfoDict - #1225
Open
saisriramlanke wants to merge 1 commit into
Open
saisriramlanke wants to merge 1 commit into
saisriramlanke wants to merge 1 commit into
Conversation
Author
|
The failing checks come from master, not from this change. Commit 6e58bd4 uses chess.STATUS_VARIANT in chess/variant.py and in test_empty_side, but it is not defined in chess/init.py, so the test and typing jobs fail on master too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1165.
InfoDict says the information is aggregated, but it does not say how. Each info line only updates the keys it contains, so the dictionary holds the latest value of every key. Values can come from different lines, and "string" keeps only the last "info string" message.
This adds a paragraph to the InfoDict docstring that explains this and points to analysis() for reading each line.
I checked it with a small fake UCI engine that sends two "info string" lines and then a depth 2 line without a pv. analyse() returned only the second string, and depth 2 with the pv from depth 1.