Repository navigation
Load TopoJson data given as a string or filename - #2353
Open
huzaifarahman13 wants to merge 1 commit into
Open
huzaifarahman13 wants to merge 1 commit into
huzaifarahman13 wants to merge 1 commit into
Conversation
TopoJson documents that data can be a str, but a TopoJSON string or a filename was kept as-is and rendering failed with AttributeError: 'str' object has no attribute 'get'. Load the string the same way GeoJson does: parse inline JSON, fetch URLs and read files.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TopoJson docstring says data can be a str, but passing a TopoJSON string or a filename crashed on render with AttributeError: 'str' object has no attribute 'get'. Same thing happened with Choropleth(geo_data="file.json", topojson=...).
Now a string is loaded the same way GeoJson does it: inline JSON gets parsed, URLs get fetched and anything else is read as a file. I updated the docstring to match and added a test for the string and filename cases. The test fails on main and passes with this change.